Repository navigation
Add support for DataView feature #196
Description
DataView objects provide an array-like view over an underlying data buffer, but one which allows items of different size and type in the ArrayBuffer.
So, we should provide wrapper implementation for the following APIs.
- napi_is_dataview() [1]
- napi_create_dataview() [2]
- napi_get_dataview_info() [3]
[1] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_is_dataview
[2] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_create_dataview
[3] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_get_dataview_info
Activity
romandev commentedon Nov 29, 2017
@mhdawson Can I start to work on this? or If we need discussions or agreements, where can I see the process for adding these new APIs?
mhdawson commentedon Nov 29, 2017
Sounds good. We should have coverage for all of the things you can do in the core N-API.
romandev commentedon Nov 29, 2017
Okay, I'll take this :)
Implement Value.isDataView()
Implement Value.isDataView()
NickNaso commentedon Sep 3, 2018
Hi @romandev,
what do you think? Could be possible close the issue?
Enable DataView feature by default
Enable DataView feature by default
Enable DataView feature by default
src: enable DataView feature by default
NickNaso commentedon Sep 18, 2018
@romandev
I think that now that #331* is landed we can close the issue.
Good work!
src: enable DataView feature by default
src: enable DataView feature by default
src: enable DataView feature by default
src: enable DataView feature by default