Repository navigation
Version Management #274
Description
Hi everyone, I want add version management functions that are available on the N-API:
napi_get_node_versionhttps://nodejs.org/dist/latest/docs/api/n-api.html#n_api_napi_get_node_versionnapi_get_versionhttps://nodejs.org/dist/latest/docs/api/n-api.html#n_api_napi_get_version
It's my intention add these two functions on Napi namespace as I did for AdjustExternalMemory see: #260
Are you agree or have some suggestions to help me?
Activity
mhdawson commentedon May 23, 2018
Makes sense to me. Not sure if creating a 'Util' object or something specific like 'Version' would be best. For these I'm leaning towards 'Util'
devsnek commentedon May 23, 2018
shouldn't you use NODE_VERSION and NAPI_VERSION instead?
NickNaso commentedon May 23, 2018
Hi @devsnek you're right it's too simple use NODE_VERSION and NAPI_VERSION, to access to these constant a developer needs only to import
node.h. My thinking is to avoid as much as possible to import anything other thannapi.h.mhdawson commentedon May 25, 2018
I agree that we want to avoid the need to import node.h as that makes it easy to take a dependency without palnning to.
NickNaso commentedon May 25, 2018
Ok in the next days I will try to add this feature.
NickNaso commentedon Sep 19, 2018
I'm closing the issue because it's solved with #325.