node-addon-api test broken on 6.x

Seems the tests were broken on 6.x when I landed 4b8918b.

It is just the test, not an ABI breakage:

Starting test suite

Running test 'arraybuffer'
Running test 'asyncworker'
module.js:478
    throw err;
    ^

Error: Cannot find module 'async_hooks'
    at Function.Module._resolveFilename (module.js:476:15)
    at Function.Module._load (module.js:424:25)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/mhdawson/newpull/node-addon-api/test/asyncworker.js:4:21)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
npm ERR! Test failed.  See above for more details.

Working on fix.

Don't worry. I have a fix, just haven't had a chance to submit it yet.

…

On Wed, Jul 11, 2018 at 4:14 PM, Michael Dawson ***@***.***> wrote: Working on fix. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7k0cAm84ZAB4Njt5OYlOp_-OQB3hPsks5uFlyngaJpZM4VLxpu> .

skip asyncworker test

test: fix asyncworker test so it runs on 6.x

Navigation Menu

Repository navigation

node-addon-api test broken on 6.x #296

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

node-addon-api test broken on 6.x #296

Description

Activity

mhdawson commented on Jul 11, 2018

gabrielschulhof commented on Jul 11, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions