You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
@mhdawson Jack needs to be able to update the table in the comment above for the work he's doing for the project.
I think it makes sense to transfer the table into a test-coverage.md file that's stored in the repository so that changes can be made and tracked using PRs. A couple of questions:
Does it make sense to create a test-coverage.md file?
Where's the best place to put the file? It could be the project root, doc, or test.
I'm happy to make whatever change we decide on.
If we decide to keep it simple and continue to maintain the information on the table above, Jack will need write access to this issue.
Hi @jschlight,
I think that could be more appropriate create separate issues for every class item in the table es. globalenv and track all the work in those issues.
In terms of documentation we need to add a guid on how to add a new test case.
About the coverage we should use some tools to create a report for the coverage.
@NickNaso suggestion will address the issue. As the originator of the new issues Jack will be able to edit them as well. So maybe close the existing one and he can open a new set of issues to cover the work.
Okay thanks everyone, just to make sure, would I need open a new issue per each class (i.e separate issues for Objects, Functions, Buffer, String etc?) I'm just wondering if it will clog up the issue tracker as there exists around 20+ classes.
Hi @JckXia,
I think you can proceed. My advice is to tag the issue you created with the test tag. If you cannot able to do that I can do it for you after you crated the issue.
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
Activity
kebahpng commentedon Sep 6, 2018
mhdawson commentedon Sep 26, 2018
From work that @andrew-cc-chen has done, this looks like the current coverage:
node-addon-api-coverage.pdf
Its not as good as the html view in that it does not show the function name being covered.
Write tests for Array class
Write tests for Array class
NickNaso commentedon Aug 26, 2019
Hi everybody,
I'm working on two PRs to add test for
Napi::ValueandNapi::String.github-actions commentedon Mar 8, 2021
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
JoseExposito commentedon Mar 10, 2021
I submitted a couple of PRs adding missing test for Object and Function.
NickNaso commentedon Mar 12, 2021
The PRs are #923 and #928
jschlight commentedon Mar 16, 2021
@mhdawson Jack needs to be able to update the table in the comment above for the work he's doing for the project.
I think it makes sense to transfer the table into a
test-coverage.mdfile that's stored in the repository so that changes can be made and tracked using PRs. A couple of questions:test-coverage.mdfile?doc, ortest.I'm happy to make whatever change we decide on.
If we decide to keep it simple and continue to maintain the information on the table above, Jack will need write access to this issue.
@JckXia
NickNaso commentedon Mar 16, 2021
Hi @jschlight,
I think that could be more appropriate create separate issues for every class item in the table es.
globalenvand track all the work in those issues.In terms of documentation we need to add a guid on how to add a new test case.
About the coverage we should use some tools to create a report for the coverage.
mhdawson commentedon Mar 16, 2021
@NickNaso suggestion will address the issue. As the originator of the new issues Jack will be able to edit them as well. So maybe close the existing one and he can open a new set of issues to cover the work.
JckXia commentedon Mar 16, 2021
Okay thanks everyone, just to make sure, would I need open a new issue per each class (i.e separate issues for Objects, Functions, Buffer, String etc?) I'm just wondering if it will clog up the issue tracker as there exists around 20+ classes.
NickNaso commentedon Mar 16, 2021
Hi @JckXia,
I think you can proceed. My advice is to tag the issue you created with the
testtag. If you cannot able to do that I can do it for you after you crated the issue.JckXia commentedon Mar 16, 2021
@NickNaso Okay thank you! Yeah it looks like I can't tag the issues. Will create the set of issues after work today.
github-actions commentedon Jun 15, 2021
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
github-actions commentedon Sep 15, 2021
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
mhdawson commentedon Sep 16, 2021
@JckXia do we still need this issue or is it replace by the other issues you created? If yes then I'll close this issue.
JckXia commentedon Sep 16, 2021
Hey @mhdawson , I think we can close this issue.
mhdawson commentedon Sep 16, 2021
@JckXia thanks for the quick response.