Skip to content

Version management documentation #358

Closed

Description

@NickNaso

There is a little inconsistency on Napi::VersionManagement documentation.

Now the two static methods exposed by Napi::VersionManagement are documented like reported below:

static uint32_t GetNapiVersion(Env env);
static const napi_node_version* GetNodeVersion(Env env);

instead they will be fixed as reported below:

static uint32_t Napi::VersionManagement::GetNapiVersion(Env env);
static const napi_node_version* Napi::VersionManagement::GetNodeVersion(Env env);

Activity

  1. nadongguri commented on Oct 1, 2018

    @nadongguri
    Contributor

    Hi @NickNaso, I will take this issue.

  2. NickNaso commented on Oct 2, 2018

    @NickNaso
    MemberAuthor

    I'm closing this issue because it has been solved with #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions