Skip to content

Object::GetPropertyNames() not const #380

Closed

Description

@AeromXundes

The method Object::GetPropertyNames() is not declared const.

The method napi_get_property_names() cannot not modify any member fields as the variables _env and _value are passed by value and result is a local variable. Thus, the function should be declared as const.

This will add the ability to declare a const Object and still get the property names associated with the object.

Activity

  1. DaAitch commented on Dec 26, 2018

    @DaAitch
    Contributor

    @AeromXundes agree: PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions