Internal/external selection broken for latest 6.x release

Looks like this logic in 437514e

Is not quite right:

var isNodeApiBuiltin = (
  versionArray[0] > 8 ||
  (versionArray[0] == 8 && versionArray[1] >= 6) ||
  (versionArray[0] == 6 && versionArray[1] >= 14 && versionArray[2] >= 2));

Branch with test fix here: https://github.com/mhdawson/node-addon-api/tree/fixselection

@NickNaso

PR for fix: #402

@NickNaso if you have time we probably want to plan a release with this fix. As of the security releases earlier this week and the bump of 6.14 -> 6.15 node-addon-api is broken for the 6.X line.

@mhdawson

Hi @mhdawson I will provide to open an issue with the intention on making new release v1.6.2.

@NickNaso

@NickNaso thanks. Landed PR and just running CI job to validate all is resolved:

https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/

CI run looks good closing.

Navigation Menu

Repository navigation

Internal/external selection broken for latest 6.x release #401

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Internal/external selection broken for latest 6.x release #401

Description

Activity

mhdawson commented on Nov 28, 2018

mhdawson commented on Nov 28, 2018

NickNaso commented on Nov 28, 2018

mhdawson commented on Nov 28, 2018

mhdawson commented on Nov 28, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions