Repository navigation
[Tests] Add test Coverage for Symbol class #957
Description
| class | methods |
|---|---|
| Covered #972 | static Symbol New(napi_env env, const std::string& description) |
| Covered #972 | static Symbol New(napi_env env, napi_value description) |
| Covered #972 | Symbol() |
| Covered #972 | Symbol(napi_env env, napi_value description) |
| Covered #972 | Symbol(napi_env env, Napi::String description) |
| Covered #972 | Symbol(napi_env env, const std::string& description) |
| Covered #972 | Symbol(napi_env env , const char* description) |
| Covered #972 | Symbol::Wellknown(napi_env env, const std::string& name) |
Activity
[-][Tests] Add tests for Symbol class[/-][+][Tests] Add test Coverage for Symbol class[/+]JckXia commentedon Mar 31, 2021
Will work on adding these tests soon.
KevinEady commentedon Mar 31, 2021
I would add
Symbol::WellKnownas well. There seems to be some discrepancy: #919JckXia commentedon Apr 15, 2021
@KevinEady Hey Kevin. For the
Symbol::Wellknownfunction, should it return a symbol that we have registered viaSymbol.for? In that if I callSymbol.for("testSymbol")on js side, I should receive the same symbol back with a call toSymbol::Wellknown("testSymbol")from Cpp? (Right now it will return undefined as stated in #919)ThomasWeinert commentedon Apr 16, 2021
I would suggest adding a separate
Symbol::For(napi_env env, const std::string& name)for fetching global symbols.github-actions commentedon Jul 16, 2021
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
NickNaso commentedon Jul 16, 2021
Hi @JckXia ,
the PR #972 has been landed. Could you provide to update the matrix of methods that needs to be tested? In case you already covered all the ceses please provide to close the issue.
JckXia commentedon Jul 16, 2021
@NickNaso Thank you for the reminder! I marked the test cases as covered and the issue is ready to be closed