Skip to content

src: remove unused CallbackScope member - #391

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:remove-unused-param
Closed

gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:remove-unused-param

Conversation

@gabrielschulhof

Copy link
Copy Markdown
Contributor

No description provided.

@NickNaso NickNaso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romandev romandev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso mentioned this pull request Nov 13, 2018
2 tasks done
mhdawson pushed a commit that referenced this pull request Nov 13, 2018
PR-URL: #391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
@mhdawson

Copy link
Copy Markdown
Member

Landed as e7cd292

@mhdawson mhdawson closed this Nov 13, 2018
@gabrielschulhof
gabrielschulhof deleted the remove-unused-param branch December 27, 2018 18:01
@gabrielschulhof
gabrielschulhof restored the remove-unused-param branch December 28, 2018 20:27
@gabrielschulhof
gabrielschulhof deleted the remove-unused-param branch February 13, 2019 23:28
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants