Repository navigation
Add blurb to N-API documentation indicating that we recommend the use of badges #22796
Description
Re: nodejs/admin#221
Re: nodejs/abi-stable-node#333
@nodejs/n-api
Re: nodejs/admin#221
Re: nodejs/abi-stable-node#333
@nodejs/n-api
Activity
Tolsee commentedon Sep 10, 2018
@gabrielschulhof Willing to contribute to Node.js and I am watching over issues I can start my journey. Add documentation will be a good start I hope. Let me know If this is something I can work on.
gabrielschulhof commentedon Sep 10, 2018
@Tolsee absolutely! Our plan is to promote the use of the following badges:
https://img.shields.io/badge/N--API-v1-green.svg
https://img.shields.io/badge/N--API-v2-green.svg
https://img.shields.io/badge/N--API-v3-green.svg
https://img.shields.io/badge/N--API-experimental-orange.svg
The addon maintainer should indicate the minimum version of N-API needed for their module. This translates to a range of supported Node.js major versions.
gabrielschulhof commentedon Sep 10, 2018
@Tolsee the file you'll want to modify is
doc/api/n-api.md.sagitsofan commentedon Sep 10, 2018
Hey @gabrielschulhof, i am willing to help also if it necessary
ddlan commentedon Sep 11, 2018
Hi @gabrielschulhof, I tried my hand at adding a blurb regarding the use of badges of N-API.
Tolsee commentedon Sep 11, 2018
Looks like I missed it 😆
siddhant1 commentedon Sep 27, 2018
Any work remaining on this one?
tiagorvmartins commentedon Nov 23, 2018
I am looking for a first issue at github, found this one, the status is open but seems like there was some references to an existing merge already, so can this be closed or can I help if needed? thanks!
mhdawson commentedon Nov 23, 2018
I think @gabrielschulhof was helping to shepherd this so I'll let him answer/close but I think the required text was added to the abi-stable-node repo.
doc: add blurb recommending the use of badges
doc: add blurb recommending the use of badges