buffer: inconsistent string validation #3770

Activity

1. thefourtheye

   added

   bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.

   on Nov 11, 2015
2. thefourtheye

   added a commit that references this issue on Jan 30, 2016

   buffer: throw if string is not a valid HEX string

   ...

   0d5f47a
3. Trott commented on Jun 6, 2016

   

   Trott

   on Jun 6, 2016

   Member

   More actions

   If it matters, the underlying issue is in Buffer.prototype.write() (which is called by the constructor in this case) and not specific to the constructor.

   buf = new Buffer(64);
   buf.write('x', 'hex'); // TypeError: Invalid hex string
   buf.write('xx', 'hex'); // 0
4. Trott commented on Mar 23, 2017

   

   Trott

   on Mar 23, 2017

   Member

   More actions

   Additionally, it seems to me that TypeError is the wrong error to throw here. A TypeError might be if something that was not a string was supplied. But an incorrectly formatted string is not a TypeError, or at least it seems to me.
5. Trott

   closed this as completedin 682573con Mar 28, 2017