Repository navigation
util,src: allow lookup of hidden values - #3988
Conversation
There was a problem hiding this comment.
If you've already verified the type then simply use .As<TYPE>()
commented
Nov 23, 2015
|
one comment, and if CI is happy then LGTM. |
commented
Nov 24, 2015
|
LGTM with the same comment as Trevor. |
commented
Nov 24, 2015
|
CI: https://ci.nodejs.org/job/node-test-pull-request/833/ UPDATE: CI looked like it had some unrelated issues. One more run, just to be sure: https://ci.nodejs.org/job/node-test-pull-request/836/ |
commented
Nov 30, 2015
|
@cjihrig ... is this a candidate for LTS? |
commented
Nov 30, 2015
|
This PR alone is of little use in LTS. It only introduces a new internal method. It should be grouped in with #4013. |
commented
Dec 5, 2015
|
why is github showing zero commits and zero changes here? I believe that 5169311 on master comes from here but it's hard to be sure. |
commented
Dec 5, 2015
|
Oh interesting. That is very strange. |
commented
Dec 5, 2015
|
Seems to be a result of landing a commit and then force pushing this branch to close the PR. Probably shouldn't do that anymore. |
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS.
I'd like to use this to more easily access the hidden
arrowMessageassociated with syntax errors. Refs #3784, #3411, #2762