Skip to content

net: update net.blocklist to allow file save and file management - #58087

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
skunksworks:main
Jul 8, 2025
Merged

net: update net.blocklist to allow file save and file management#58087
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
skunksworks:main

Conversation

@alphaleadership

@alphaleadership alphaleadership commented Apr 30, 2025 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Fixes: #56252

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 30, 2025
@alphaleadership

ghost commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

#56252 is patch by that

@alphaleadership

ghost commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell

jasnell
jasnell reviewed May 7, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
@alphaleadership
alphaleadership requested a review from jasnell May 7, 2025 07:41
@alphaleadership

ghost commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@nodejs/net

@alphaleadership

ghost commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell

jasnell
jasnell reviewed May 12, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 12, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 12, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
@alphaleadership
alphaleadership requested a review from jasnell May 13, 2025 06:13
@alphaleadership

ghost commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell

@alphaleadership

ghost commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

@aduh95

jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
jasnell
jasnell reviewed May 15, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
@alphaleadership

ghost commented May 16, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell

@alphaleadership

ghost commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

@aduh95 @jasnell

@alphaleadership
alphaleadership requested a review from jasnell May 23, 2025 08:59
@alphaleadership

ghost commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell

jasnell
jasnell reviewed Jun 4, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
@alphaleadership
alphaleadership requested a review from jasnell June 4, 2025 14:16
jasnell
jasnell reviewed Jun 10, 2025
View reviewed changes
Comment thread lib/internal/blocklist.js Outdated
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 8, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 4de0197 into nodejs:main Jul 8, 2025
@nodejs-github-bot

ghost commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4de0197

@Ethan-Arrowood

ghost commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

@alphaleadership

ghost commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

thanks for the merge
i can publish some module in the npm registry

@github-actions github-actions Bot mentioned this pull request Jul 28, 2025
Merged
@RafaelGSS RafaelGSS mentioned this pull request Aug 12, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Aug 26, 2025
Merged
@AlCalzone AlCalzone mentioned this pull request May 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node:net blocklist upgrade

4 participants

@alphaleadership @jasnell @nodejs-github-bot @Ethan-Arrowood