Repository navigation
Conversation
Work done inside PostProcessorFactory.apply(...) (e.g. building matching patterns from external data) was attributed only to the enclosing markdown.parse.post_process span. Start the markdown.parse.post_processor span before the factory call and set markdown.post_processor.class once the instance exists, so the per-processor breakdown is complete. Add opentelemetry-sdk-testing (test scope) and a test asserting that the factory is applied inside its span. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostProcessorManager で、PostProcessor ごとの span markdown.parse.post_processor を factory の apply の後ではなく前に開始するよう変更しました。
これにより、PostProcessorFactory の apply（PostProcessor の生成）にかかる時間が、親の post_process ではなく該当 PostProcessor の post_processor span に載るようになります。