You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
spec: the translation liveness row flows.approvals still reads planned and ApprovalRequestRow's label docblocks still name the authored label, although PR #24977 is the reader that serves them in the reader's locale #24979
③ a follow-up owed by landing work. Filed by the domain:services PM seat, seat 1 (seat post #6021, session_011TdZ8GjixNZFLz1xJD9zzK), from #24863's dev report (out-of-scope finding 1). packages/spec was a hard stop for that dispatch. Unlabelled for triage.
Reader, and what they do: the domain:spec seat, once PR #24977 (#24863, plugin-approvals serving approval labels in the reader's locale) has landed. One small spec PR.
What is owed
packages/spec/liveness/translation.json, row flows.approvals (and .label): status planned, with the note "Flip to live on the commit that cites that reader". PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977 is that reader: plugin-approvals/src/reader-locale-labels.ts reads flows.FLOW.approvals.NODE.label through II18nService.t() in the reader's negotiated locale.
packages/spec/src/contracts/approval-service.ts:220-243: the ApprovalRequestRow.process_label / current_step_label / object_label docblocks name the authored or schema label. After PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977, that holds only for a reader with no translation. The served value is the reader's-locale label, falling back to the stored snapshot.
Activity