ADR-0057 data lifecycle follow-ups: retire per-plugin sweepers, dev telemetry datasource + db:clean, Studio surface, PG rotation (tracking) #2834

Activity

1. os-zhuang

   added

   enhancementNew feature or requestNew feature or request

   on Jul 11, 2026
2. os-zhuang commented on Jul 11, 2026

   

   os-zhuang

   on Jul 11, 2026 – with Claude

   ContributorAuthor

   More actions

   ④ PostgreSQL native-partition Rotator — evaluated, deferred with a design sketch (not shipping unverified DDL)

   Neither this environment nor CI has a PostgreSQL service (driver-sql tests run better-sqlite3 only), so a PARTITION BY RANGE implementation would land as code no test can ever execute — exactly the unverified-claim class ADR-0049/0054 exist to block. Current behavior on PG is already correct (rotation falls back to an equivalent age-based reap; the declared bound holds — only reclamation is row-wise instead of O(1)), so this is an optimization, not a gap.

   Design sketch for whenever a PG service lands in CI:

   • SqlDriver.supportsRotation becomes dialect-aware (isSqlite || isPostgres).
   • PG path in ensureRotation: base table converted once to PARTITION BY RANGE (created_at) (requires a rebuild: rename → create partitioned → attach legacy as the first partition); per-period partitions <table>__r<key> created via CREATE TABLE … PARTITION OF … FOR VALUES FROM/TO; expiry = DETACH PARTITION CONCURRENTLY + DROP TABLE (O(1), lock-light).
   • No view needed (unlike SQLite): the partitioned parent IS the queryable name, and writes route by the partition key natively — the shard-wise write redirects the SQLite path needs don't apply.
   • Prereqs: a postgres service container in the CI dogfood/driver jobs + a sql-driver-rotation.pg.test.ts gated on OS_TEST_PG_URL.

   Also noted while doing ③ (i18n regen): the *.objects.generated.ts bundles have extract-config drift. The committed bundles carry curated zh-CN translations for objects (e.g. sys_audit_log) that live outside packages/platform-objects/scripts/i18n-extract.config.ts's import set (plugin-audit etc.) — so a plain re-run of os i18n extract deletes those curated translations. ③'s PR therefore regenerated only the metadata-forms bundles and left the objects bundles untouched. Fix candidates: import the missing sys_* objects into the extract config, or split per-package bundles. Worth its own small item before anyone re-runs the extractor for object keys.

   🤖 Generated with Claude Code

   ---

   Generated by Claude Code
3. os-zhuang

   added 2 commits that reference this issue on Jul 11, 2026

   feat(lifecycle): ADR-0057 follow-ups — retire per-plugin sweepers, de…

   ...

   526805e

   feat(lifecycle): retention.onlyWhen status predicate + declarative au…

   ...

   33ebd34
4. os-zhuang

   self-assigned this

   on Jul 15, 2026
5. os-zhuang commented on Jul 15, 2026

   

   os-zhuang

   on Jul 15, 2026 – with Claude

   ContributorAuthor

   More actions

   Closing — every item is now resolved:

   • ①–③ shipped in feat(lifecycle): ADR-0057 follow-ups — retire per-plugin sweepers, dev telemetry datasource + db:clean, Studio lifecycle form (#2834) #2835; ①'s remaining caveat (no status predicate) was closed by retention.onlyWhen in feat(lifecycle): retention.onlyWhen status predicate + declarative automation run-history retention + i18n bundle ownership guard (#2834) #2837.
   • ④ (PG native-partition Rotator) is dropped by decision: the age-based fallback on PG is correct and the retention bound holds, so native partitioning is a pure reclamation optimization — not worth an open tracking item while CI has no PostgreSQL service to verify the DDL against. The design sketch above stands if it's ever picked back up.
   • ⑤ shipped in feat(lifecycle): retention.onlyWhen status predicate + declarative automation run-history retention + i18n bundle ownership guard (#2834) #2837 (stray sys_* translations pruned to their owning packages' bundles + the bundle-ownership.test.ts guard); verified on current main that the platform-objects bundles are clean and the guard is in place.

   🤖 Generated with Claude Code

   ---

   Generated by Claude Code
6. os-zhuang

   closed this as completedon Jul 15, 2026
7. os-zhuang

   added a commit that references this issue on Jul 26, 2026

   chore(i18n): purge dead sys_webhook_delivery bundle block + roll out …

   ...

   52281b0
8. akarma-synetal

   added a commit that references this issue on Oct 7, 2026

   test(spec): the fourth data/ file group's test titles state each cite…

   ...

   124533b