Repository navigation
Re-annotate plugin-sharing + plugin-audit onto the full ExecutionContext and delete the double-casts (identity half of #7070) #7136
Description
Identity-lane half of the #7070 split (promotion executed by the triage seat per the split plan recorded on that card, 2026-08-09). The contract half is done: #6523 / PR #7068 converged 36 contract signatures onto the full ExecutionContext. This card widens the implementation-side annotations in the identity lane so the casts the narrow type forced become deletable.
File face (verified on origin/main @ 445a0c2)
| file | SharingExecutionContext refs |
|---|---|
packages/plugins/plugin-sharing/src/sharing-service.ts |
21 |
packages/plugins/plugin-sharing/src/sharing-rule-service.ts |
8 |
packages/plugins/plugin-sharing/src/exec-context-seam.testkit.ts |
3 |
packages/plugins/plugin-audit/src/comment-access-hooks.ts |
2 |
The double-cast specimen, re-verified live: exec-context-seam.testkit.ts:106 — return { ...authz, isSystem: false } as unknown as SharingExecutionContext; — the helper resolves a REAL resolveAuthzContext envelope and then has to force it into the narrow type to hand it to the service.
Scope boundary (both inherited from #7070)
- ⛔ Any
organizationIdspellings stay out — per [#5852 契约半边]HierarchyScopeContext未声明organizationId/tenantId哪个权威 —— producer 只填一个、consumer 只读另一个,两边都「符合契约」 #5858 /check:org-identifierthat vocabulary has its own history; this card is annotation widening + redundant-cast deletion only. - The removal of the exported
SharingExecutionContexttype itself rides whichever of the two split halves lands second. finding:SharingExecutionContext是同族第四个窄 enforcement 契约类型(sharing / approval / report 三个服务共用),#6206 裁决的「不留 per-site 子集」默认尚未覆盖它 #6523 deliberately left it exported and documented as migration residue precisely to keep these files compiling; once both halves land, it becomes removable — the second-lander deletes it (or files the one-line follow-up if cross-lane timing makes that cleaner).
No user-visible defect: values are complete at runtime (the #6523 family's damage was type-side). No compiler pressure will surface this — PR #7068 measured the dependents-direction typecheck green — which is why it is queued deliberately.
Part of #7070 (progress view). Sibling: services half (#7135). Refs: #6523, PR #7068, #6206 (ruling), #6430 / PR #6511.
Activity
SharingExecutionContext, so(context as any).postureis still needed to read a field the contract now declares #7070os-zhuang commentedon Aug 9, 2026
Claim — identity-lane PM seat (#6022), session
session_01BM1tNf5U3nEbHKR4fo5qVQ. Dispatching to anos-devsubagent now.claude/issue-7136-exec-context-annotations../objectstack-issue-7136(dedicated per-task worktree; never the shared checkout)domain:identity— label untouched (single-producer rule; promoted by the triage seat 19:26Z via the recorded finding: consumer half of #6523 — three plugin implementations still annotateSharingExecutionContext, so(context as any).postureis still needed to read a field the contract now declares #7070 split plan)pm:queue→pm:dispatched. Thread re-read before claiming: zero prior comments, no assignee, no competing session ID.File surface as measured on the card (
origin/main@445a0c2; the claimant re-measures at its own branch point):plugin-sharing/src/sharing-service.ts(21 refs),sharing-rule-service.ts(8),exec-context-seam.testkit.ts(3),plugin-audit/src/comment-access-hooks.ts(2).Serial constraints cleared: the identity lane has nothing in flight — #5814 landed 18:44Z (PR #7124) and the lane's only other open item, cloud#1220, is a different repo entirely. The sibling #7135 is
domain:services, a different seat and a disjoint file set; both are unclaimed as of this comment, so neither blocks the other.Coordination point carried to the claimant, from the card: removing the exported
SharingExecutionContexttype rides whichever of the two split halves lands second. So the claimant must check #7135's state at landing time — delete the type only if the services half is already in; otherwise leave it exported (it is documented migration residue that keeps those files compiling) and file the one-line follow-up. Do not delete it speculatively, and do not touchpackages/services.⛔ Boundary inherited from #7070: any
organizationIdspellings stay out — per #5858 /check:org-identifierthat vocabulary has its own history. This card is annotation widening plus redundant-cast deletion only.Note for the claimant on how to verify this one bites: the card states there is no user-visible defect and no compiler pressure (values are complete at runtime; PR #7068 measured the dependents-direction typecheck green). So a passing typecheck proves nothing on its own — the evidence that the work happened is the casts being gone, and the claimant should say how it established that rather than resting on a green suite.
If a claim comment with a different session ID appears above this one, that claim wins by timestamp and this seat stands down.
Generated by Claude Code
fix(plugin-sharing): SYSTEM_CTX cast count is 10, not 11 (#7136)
refactor(plugin-sharing,plugin-audit): annotate enforcement on the fu…
fix(plugin-audit): forward the caller's execution envelope to the sys…