Skip to content

conversions/registry.ts is now the last hand-authored append registry — extend the #7297 per-entry split? #7464

Closed as not planned

Description

@os-zhuang

Filed from PR #7454's open question (spec-lane PM seat #6017); recording only, not claiming.

Context

PR #7454 (#7297) split packages/spec/src/migrations/registry.ts's three append tables (59 semantic / 16 retired-keys / 45 retired-defs entries) into per-entry files under packages/spec/src/migrations/entries/{semantic,retired-keys,retired-defs}/, generated back into registry.ts between markers by build-migration-registry.ts (gen:/check:migration-registry, --self-test). Concatenation stays inside registry.ts because the browser-reachable barrel forbids readdirSync; LEDGER_SOURCES was deliberately unchanged.

conversions/registry.ts was deliberately excluded per the dispatch ruling "when in doubt, migrations only" — leaving it the last hand-authored append registry in the package.

Question for triage

Does the same merge-conflict/append-contention argument that justified #7297 apply to conversions/registry.ts, and if so does build-migration-registry.ts generalize or does the conversions table need its own generator? A quick churn measurement (how often that file's append tables take concurrent edits) would settle the priority.

Natural lane if promoted: domain:spec. Reference implementation: PR #7454.

Activity

  1. claude commented on Aug 10, 2026

    @claude
    Contributor

    Routing only: domain:spec appended; finding grading unchanged, no ownership taken.

    Route-A repair — a finding with no routing label is invisible to every lane at the moment it gets promoted. Landing verified on origin/main @ 603cab8: packages/spec/src/conversions/registry.ts exists and is the surface the question is about; the reference implementation's tree (packages/spec/src/migrations/entries/{semantic,retired-keys,retired-defs}/) is on main. Criteria: direct precedent #7297 (the migrations-registry split this card proposes extending) ran as domain:spec, and the filing seat (#6017) itself names domain:spec as the natural lane. Not spec-surface (this is registry structure, not describe/JSDoc text) and not spec-tooling (the deliverable is the registry split in packages/spec/src, the generator is the means).

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  2. claude commented on Aug 10, 2026

    @claude
    Contributor

    Findings triage: CLOSED (not planned) — the card's own question answered by the measurement it asked for.

    The card asked whether the merge-conflict/append-contention argument behind #7297 applies to conversions/registry.ts, and said "a quick churn measurement (how often that file's append tables take concurrent edits) would settle the priority." Measured this round on origin/main @ 333769d: 1 commit touching packages/spec/src/conversions/registry.ts since 2026-07-10 — no concurrent-append contention exists to justify extending the per-entry split today. The file is verified still hand-authored (no generated-entry markers), so the premise was intact; it is the priority that measures to nil. Reopen if that file's churn rises to where entries collide in flight — PR #7454 remains the reference implementation. Maintainer may veto by reopening.

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions