Repository navigation
chore(qa): drop dead src/**/* include glob from dogfood tsconfig - #11474
Merged
Merged
Conversation
The dogfood package is test-only by design: its tree is CHANGELOG.md, README.md, package.json, test/, tsconfig.json, vitest.config.ts. The `src/**/*` include glob has never matched anything. Measured with `tsc --showConfig -p packages/qa/dogfood/tsconfig.json` before and after: the resolved `files` array is byte-identical (151 entries, same order), `compilerOptions` and `exclude` unchanged. The only delta in the whole emitted config is the echoed dead glob itself. `rootDir` and its comment are deliberately untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ahemw8RcTgqtxrj15PEZx
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 2 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
os-steve
marked this pull request as ready for review
August 23, 2026 21:46
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10899
packages/qa/dogfoodis test-only by design. Itstsconfig.jsondeclaredinclude: ["src/**/*", "test/**/*"], and the package has nosrc/. One globremoved; nothing else in the file touched.
The load-bearing measurement: the program tsc compiles is unchanged
tsc --showConfig -p packages/qa/dogfood/tsconfig.json, TypeScript 6.0.3 (theversion the package declares), run before and after the edit:
filesentriesfilesidentical, same ordertrue[]/[]compilerOptionsidenticaltrueexcludeidenticaltrueincludeas echoed["src/**/*","test/**/*"]["test/**/*"]diffover the two complete--showConfigoutputs is exactly one line:That single line is the echoed glob itself. Every one of the 151 resolved files
is under
./test/; the dead glob contributed none of them. This is a removal ofa declaration, not a change to the compiled program.
Ratchets: reverse-verified, readings do not move
The fix was committed first, then
git restore --source=stood the base fileback up (tree only — porcelain showed a lone
M, neverMM), the two ratchetsthat read tsconfig
includesets were re-run, and the file was restored.Both printed byte-identical verdict lines at base and at head:
The
generated layerrow isapps/docs, untouched by this diff.dogfood'ssrcroot was never in that population: that invariant's detector asks whetheran
includeroot is gitignored, andsrchere is neither checked in norignored — the distinction #10880 drew deliberately.
Gates
Derived with
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack(no paths passed; it takes its own change set from the merge base), then treated
as a floor. All run at
99eee07a, exit codes captured before any pipe:check:empty-state(spec)check:liveness(spec)check:strictness-ledger(spec)check:variant-docs(spec)check:published-filescheck:slot-lookupcheck:test-source-aliascheck:type-source-resolutioncheck-ci-filter-parity.mjscheck-plugin-teardown-shape.mjscheck-affected-docs.mjscheck:type-check-coveragecheck:nul-bytescheck:type-check-coverageis the floor extension that matters here: it readsevery package's
includearray, and the derivation did not name it.Declared narrowing: repo-wide
pnpm lintnot runMeasured rather than assumed, all three pieces:
pnpm exec eslint --no-inline-config --format json packages/qa/dogfood/tsconfig.jsonreturns one result whose only message is
File ignored because no matching configuration was supplied.The changed file is not in eslint's population.--format json. 1 result entry, 0 errors, 1 warning,and that warning is the not-configured notice above — 0 files in this diff
are linted.
eslint.config.mjsstates in-repo, witha positive control behind it, that this repo "never enables type-aware
linting (no
parserOptions.project, no typed@typescript-eslintrules) forANY file, test or not." No tsconfig
includechange can move an eslintverdict on a file it does not appear in.
Deliberately not done
src/directory created. The declaration was wrong, not the tree.rootDir: "../../.."and its comment untouched. That shape is load-bearing— the route-ledger to live-mount parity gate imports five sibling packages'
ledgers as relative sources — and was reasoned about. Only the dead glob moved.
@objectstack/dogfoodisprivate: trueand this diffchanges no published artifact;
skip-changesetis applied.Files changed
packages/qa/dogfood/tsconfig.json— 1 insertion, 1 deletion.Generated by Claude Code