Skip to content

Remove redundant field name declarations in object protocol #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Jan 25, 2026
Merged

Remove redundant field name declarations in object protocol #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d1177
Initial plan
Copilot Jan 25, 2026
3e6cc2d
Remove redundant field name properties from object.test.ts
Copilot Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions packages/spec/src/data/object.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,27 +111,23 @@ describe('ObjectSchema', () => {
pluralLabel: 'Contacts',
fields: {
first_name: {
name: 'first_name',
label: 'First Name',
type: 'text',
required: true,
maxLength: 50,
},
last_name: {
name: 'last_name',
label: 'Last Name',
type: 'text',
required: true,
maxLength: 50,
},
email: {
name: 'email',
label: 'Email',
type: 'email',
unique: true,
},
phone: {
name: 'phone',
label: 'Phone',
type: 'phone',
},
Expand All @@ -156,7 +152,6 @@ describe('ObjectSchema', () => {
nameField: 'opportunity_name',
fields: {
opportunity_name: {
name: 'opportunity_name',
label: 'Opportunity Name',
type: 'text',
},
Expand All @@ -173,12 +168,10 @@ describe('ObjectSchema', () => {
name: 'user',
fields: {
email: {
name: 'email',
label: 'Email',
type: 'email',
},
username: {
name: 'username',
label: 'Username',
type: 'text',
},
Expand Down Expand Up @@ -251,26 +244,22 @@ describe('ObjectSchema', () => {
nameField: 'account_name',
fields: {
account_name: {
name: 'account_name',
label: 'Account Name',
type: 'text',
required: true,
maxLength: 255,
},
account_number: {
name: 'account_number',
label: 'Account Number',
type: 'text',
unique: true,
externalId: true,
},
website: {
name: 'website',
label: 'Website',
type: 'url',
},
industry: {
name: 'industry',
label: 'Industry',
type: 'select',
options: [
Expand All @@ -280,14 +269,12 @@ describe('ObjectSchema', () => {
],
},
annual_revenue: {
name: 'annual_revenue',
label: 'Annual Revenue',
type: 'currency',
precision: 18,
scale: 2,
},
owner_id: {
name: 'owner_id',
label: 'Account Owner',
type: 'lookup',
reference: 'user',
Expand Down Expand Up @@ -322,13 +309,11 @@ describe('ObjectSchema', () => {
nameField: 'subject',
fields: {
subject: {
name: 'subject',
label: 'Subject',
type: 'text',
required: true,
},
status: {
name: 'status',
label: 'Status',
type: 'select',
options: [
Expand All @@ -338,7 +323,6 @@ describe('ObjectSchema', () => {
],
},
priority: {
name: 'priority',
label: 'Priority',
type: 'select',
options: [
Expand All @@ -348,25 +332,21 @@ describe('ObjectSchema', () => {
],
},
project_id: {
name: 'project_id',
label: 'Project',
type: 'master_detail',
reference: 'project',
deleteBehavior: 'cascade',
},
assigned_to: {
name: 'assigned_to',
label: 'Assigned To',
type: 'lookup',
reference: 'user',
},
due_date: {
name: 'due_date',
label: 'Due Date',
type: 'date',
},
completed_at: {
name: 'completed_at',
label: 'Completed At',
type: 'datetime',
},
Expand Down
Loading