Repository navigation
Wire check-harness-current.mjs and check:pm-expected-skips self-tests into lint.yml - #18388
Merged
os-elon-musk merged 2 commits intoSep 16, 2026
Merged
Conversation
Adds a self-test step beside the other check:pm-* steps so scripts/pm/check-expected-skips.mjs's --self-test runs on every PR and check-self-test-wired starts counting it. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bz6hxDBqK62NP2W1LATvnt
…-history collector Adds a run_self_test line to lint.yml's "Shallow-history guard self-tests" collector step so scripts/pm/check-harness-current.mjs's --self-test runs on every PR and check-self-test-wired starts counting it. Syncs the step's closing prose (three -> four). Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bz6hxDBqK62NP2W1LATvnt
os-elon-musk
marked this pull request as ready for review
September 16, 2026 08:22
os-elon-musk
deleted the
claude/issue-18356-lint-yml-pm-self-test-wiring
branch
September 16, 2026 08:42
This was referenced Sep 16, 2026
docs(pm-dispatch): re-key platform-readings' GraphQL-only list now the ccr routes are counted
#18396
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18356
Fixes #18358
What changed
Two independent one-line wirings into
.github/workflows/lint.yml, one per linked card, each landed as its own commit socheck-self-test-wired.mjsstarts counting a--self-testthat already ships onmainbut that no workflow names.#18356 —
check-harness-current.mjs --self-testinto the "Shallow-history guard self-tests" collectorShallow-history guard self-testsstep'srun:block (the collectorcheck-step-collectors.mjs --self-testextracts and drives).run_self_testlines (git-history.mjs,check-engine-split-ratio.mjs,collect-release-notes.sh), closing prose read "all three ran and passed".run_self_test node scripts/pm/check-harness-current.mjs --self-test— and the closing prose updated to "all four ran and passed" (the FAILED-branch prose is unchanged; it already names failures generically).node scripts/check-step-collectors.mjs --self-test(182 assertions, 5 live blocks) andnode scripts/check-step-collectors.mjs(the live gate) both pass;node scripts/pm/check-harness-current.mjs --self-testpasses standalone (14 of 14 cases) both before and after the wiring.#18358 —
pnpm check:pm-expected-skipsbeside the othercheck:pm-*stepscheck:pm-*step block, immediately afterSettings deny-roster pin (#18281)(pnpm check:pm-settings-deny-roster) and before the release-rehearsal step — the same "self-test only, live check stays a seat tool" shape as the widening-tell and prior-ruling-reader steps beside it.check:pm-expected-skipsorcheck-expected-skips.mjs.pnpm check:pm-expected-skips.pnpm check:pm-expected-skipspasses locally (99 of 99 cases).check-self-test-wired— before / afterBEFORE, on origin/main at 8b81ab6:
AFTER, on this branch:
212 to 214 run by CI (both new scripts counted "through the flag": 209 to 211).
check-harness-current.mjsandcheck-expected-skips.mjsare the two scripts that moved.Gates
Derived via
node scripts/pm/dispatch-gates.mjs --commandsagainst merge-base8b81ab60d(41 commands: 21pnpm, 20 directnode). All 40 non-lock commands ran locally and passed, exceptpnpm check:type-check-debt, which reported PREREQUISITE NOT MET (exit 3, not a finding — the ledgered packages' workspace dependencies have no built dist type entry point in this worktree; the script's own text says a re-measure without the closure built would silently measure a different world).pnpm check:pm-dispatch-gates(single-machine roughly 430 to 450 seconds) ran through the shared verify lock.node scripts/pm/check-governed-merges.mjs --test .github/workflows/lint.ymlreports NOT governed at exit 0, as expected for a workflow-only diff.node scripts/pm/check-clause2-carriers.mjs --pair 18388reports both cards' clause-2 declaration readable in the fixed spelling, both carriers agreeing, and no widening tell on either diff (exit 0).skip-changeset
No published package's shipped content moves — the diff is entirely inside
.github/workflows/lint.yml, which is not published.skip-changesetapplied.Acceptance notes
None — both cards' file surfaces were exactly as scoped (one collector line plus its closing prose, one new step), and no reproducible defect, contract violation or metadata-authoring trap was found while touching this file.
Generated by Claude Code
Generated by Claude Code