Skip to content

docs(agents): say what the required lint job verifies about the SDUI manifest #19713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 2 commits into from
Sep 22, 2026
Merged

docs(agents): say what the required lint job verifies about the SDUI manifest #19713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3419bd8
docs(agents): say what the required lint job verifies about the SDUI …
claude Sep 22, 2026
90fe409
Merge origin/main into claude/issue-18818-agents-md-sdui-manifest-lin…
claude Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,15 +757,15 @@ Principles the wrapper encodes (its own output is the authority on detail):

**`check:react-declaration-parity` compares two DECLARATIONS, not a declaration against an
implementation** — the props the spec zod schema declares vs the inputs the objectui
registry config declares. A prop both sides declare and no renderer reads is, to this gate,
perfect agreement. Its `spec-only` / `registry-only` / `missing` signals are real; just
don't read it as proof anything renders. Its right-hand side is the **tracked repo-root
`sdui.manifest.json`**, written by `node scripts/gen-sdui-manifest-node.mjs` beside
`scripts/sdui-manifest.record.json` and held honest in the required lint job by
`scripts/check-sdui-manifest.mjs` — so `lint.yml` runs this gate `--strict` against it on
every PR. It still **exits 1** with no usable manifest and `check:generated` files it
`EXTERNAL_INPUT_REQUIRED` because that aggregate hands it none. ⛔ Do not "fix" a red by
re-adding a skip.
registry config declares. Its `spec-only` / `registry-only` / `missing` signals are real;
just don't read it as proof anything renders. Its right-hand side is the **tracked
repo-root `sdui.manifest.json`** and its record `scripts/sdui-manifest.record.json`, which
the required lint job's `scripts/check-sdui-manifest.mjs` checks OFFLINE only — existence,
shape, sha256 vs the record, record pin vs `.objectui-sha`; its version-vs-pin leg runs
only where an objectui checkout is in hand, so lint prints `NOT CHECKED` by design.
`lint.yml` runs THIS gate `--strict` against it on every PR; it still **exits 1** with no
usable manifest and `check:generated` files it `EXTERNAL_INPUT_REQUIRED` because that
aggregate hands it none. ⛔ Do not "fix" a red by re-adding a skip.

Two generators have **no** gate at all — `gen:openapi` and `gen:sbom`. Nothing verifies
their output is current; the wrapper reports that each run rather than staying silent.
Expand Down
Loading