Repository navigation
docs(qa): withdraw the retired sys_account.issuer from two checklist carriers - #19826
Merged
Merged
Conversation
…carriers identity-auth.linked-accounts-social required "issuer stamped" in a step and "issuer is stamped" in its first acceptance verify; sys_account.issuer retired with better-auth 1.7.3, so that oracle failed a healthy system. Both clauses now state (provider_id, account_id) is the identity and cite the retirement's migration entry; revision 2 recorded in history. FOLLOW-UPS.md section 6's persona row cited the issuer derivation as closing evidence; the clause is withdrawn with a visible correction note. Claude-Session: https://claude.ai/code/session_01VDtqoecgES7ScQYGbFVDRv Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Sep 23, 2026
Contributor
Author
Contract reviewServed-tier: ① Derived judgments
② Semver level
③ Boundary flags
Implemented-by: VERDICT: PASS Isolated at-tier reviewer, adopted by the Generated by Claude Code |
objectstack-fleet
Bot
deleted the
claude/issue-19217-issuer-carriers
branch
September 24, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19217
Clause-②: no
What changed
Two QA-checklist carriers still required or cited
sys_account.issuer, a column that retired with better-auth 1.7.3 (durable record:packages/spec/src/migrations/entries/semantic/18.sys-account-issuer-retired.ts). Docs/QA only; no code, no published package source.docs/qa/platform-checklist/areas/identity-auth.json, itemidentity-auth.linked-accounts-social: the ORACLE. The step 「issuer stamped」 and the first acceptance clause's verify 「issuer is stamped」 are both withdrawn. The same shape PR docs(qa): re-anchor three approvals knownGaps on the sys_account.issuer retirement #19213 used forapprovals.json: the reason is kept (the step now says(provider_id, account_id)is the whole account identity and names the retirement's migration entry), and the verify says an issuer-less row is the healthy shape, never a FAIL.revision1 -> 2 with an appendedhistoryentry; revision 1's history entry is untouched.docs/qa/platform-checklist/FOLLOW-UPS.mdsection 6, the "second signed-up (non-admin) user in seeds" row: the closing-evidence clause "issuer derived from the dev admin's own row" is withdrawn. The file's own rule is append-never-rewrite, so the correction is made visibly in place (the pattern section 10's E2 row already uses): the row says what the seed does today (ensureCredentialAccount-> better-authinternalAdapter.createAccount, keyed on(provider_id, account_id), read atexamples/app-showcase/src/security/seed-approval-demo.tsensureCredentialAccountand the comment above its call site), and records that it used to claim an issuer derivation, withdrawn with this card.Premise, re-measured on
c1185240(branch base)identity-auth.jsonstep at:1119and verify at:1128carried the dead requirement (card said:1118/:1127).FOLLOW-UPS.md:151carried the falsified clause.packages/qa/dogfood/test/showcase-demo-personas-loginable.dogfood.test.ts:133-138asserts the admin's account row has NOissuerown-property ("sys_account.issuer retired with better-auth 1.7.3 — nothing should still be writing it"); only its header comment changed.issuerhits inidentity-auth.jsonare the OIDC discovery-documentissuer(:178,:233,:235,:250,:275) and the TOTP otpauth labelissuer + account(:1287,:1302) — different concepts, correct.areas/approvals.json's hits are all inhistoryentries or closed-by-fixtureknownGapstext — the correct steady state, not in scope.areas/ai.json:697/719is the OAuth issuer URL in a boot-log warning — unrelated.Verification (at
f7fb5a98)Gate list derived with
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands(13 commands), every one run, reconciled with--rancarrying exit codes: "13 derived famil(ies) accounted for — 13 run, 0 NOT-MEASURED (a DERIVED zero)".pnpm check:platform-checklistexit 0: "OK — 15 areas, 265 items ... symbol anchors: 619/637 resolved ... 17 file floors held".areas/identity-auth.json83 against floor 82,FOLLOW-UPS.md4 against floor 2. No floor or ledger moved. (identity-auth.jsonhas one anchor of headroom — the new migration citations are bare paths, which add and remove no anchor.)pnpm check:doc-authoring,check:nul-bytes,check:cross-package-test-inputs,check:driver-memory-census,check:gitlink-declared,check:refd-timer-probe,check:watch-hint-literal,check-ci-filter-parity,check-closing-keyword-parity(+--self-test),check-comment-mask-corpus: all exit 0.@objectstack/lint check:doc-formula-expressions: first run exit 3 (PREREQUISITE NOT MET —@objectstack/formula/@objectstack/lintunbuilt, nothing measured); afterturbo run buildof those two, exit 0.Changeset
None. The diff is
docs/qa/**only and publishes nothing from any released package, so this isskip-changesetterritory; the label is left to the PM seat.Acceptance notes
Generated by Claude Code