Repository navigation
feat(ai): split ask/build agents by surface + tool scoping (ADR-0063/0064) - #2181
Merged
Merged
Conversation
…0064) Implements the framework side of #2168. spec: - SkillSchema gains `surface: 'ask'|'build'|'both'` affinity (ADR-0063 §3). - AgentSchema gains `surface: 'ask'|'build'` (the product it binds). - `agent` metadata-type → allowRuntimeCreate:false, allowOrgOverride:false (ADR-0063 §2: *.agent.ts closed to third parties). service-ai (`ask`): - Rename data-chat-agent.ts → ask-agent.ts; DATA_CHAT_AGENT → ASK_AGENT, DEFAULT_DATA_AGENT_NAME → ASK_AGENT_NAME (LEGACY_DATA_AGENT_NAME kept). - `ask` persona is data-only: drop the ADR-0040 unified "INTENT FIRST" build/data classifier; it declines app-building and points at the Builder. - New `schema_reader` (surface:'both') owns the shared read tools describe_object/list_objects/query_data; data_explorer/actions_executor marked surface:'ask' and stop dual-listing the shared reads. - Remove the `buildRegisterActive` degradation shim in agent-runtime. - resolveActiveSkills now hard-fails on incompatible skill↔agent surface (ADR-0064 §3); listAgents filters the catalog to platform agents only. - Tests: tools(ask) carries no create_*/*_metadata/blueprint tools; a surface:'build' skill bound to ask is a load error; surface:'both' binds. Verified: turbo build (spec+service-ai DTS) green; 404/404 service-ai tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 3 package(s): 95 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
agent.allowOrgOverride is now false (tenant custom agents withdrawn), so the registry-derived OVERLAY_ALLOWED_TYPES no longer contains 'agent'. Update the source-of-truth invariant assertion to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 22, 2026
Closed
Merged
xuyushun441-sys
added a commit
that referenced
this pull request
Jun 22, 2026
…t model (ADR-0063/0064) (#2194) Finishes the prose sweep that #2168 closed on prematurely, and lands the two #2165 doc items that had no home in the skill-authoring contract: - Rewrite the "Built-in Unified Assistant (ADR-0040)" section to the two surface-bound agents (`ask` OSS/free, `build` cloud/paid). `data_chat` / `metadata_assistant` now appear ONLY in the alias-table note, never as vocabulary. - Document the `surface: 'ask' | 'build' | 'both'` skill field, the built-in skills' affinities, and that an agent's tools = the union of its surface-compatible skills' tools (no global fall-through; affinity is a load error). - Document that `surface:'build'` skills are inert on OSS — intentional tiering, not a bug — and that a build-intent turn degrades gracefully. - Reconcile the stale "0040 unified assistant" row in adr/PRIORITIZATION.md (tool-scoping shipped via #2181; only the blueprint scale gate remains). Generated skill docs unchanged (generator reads frontmatter only). Refs #2165 #2168 Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the framework side of #2168 (ADR-0063 two agents bound by surface; ADR-0064 tool scoping).
spec
SkillSchemagainssurface: 'ask'|'build'|'both'affinity (ADR-0063 §3).AgentSchemagainssurface: 'ask'|'build'(the product it binds).agentmetadata-type →allowRuntimeCreate:false, allowOrgOverride:false(ADR-0063 §2:*.agent.tsclosed to third parties).service-ai (
ask)data-chat-agent.ts→ask-agent.ts;DATA_CHAT_AGENT→ASK_AGENT,DEFAULT_DATA_AGENT_NAME→ASK_AGENT_NAME(LEGACY_DATA_AGENT_NAMEkept).askpersona is data-only: drop the ADR-0040 unified "INTENT FIRST" classifier; it declines app-building and points at the Builder.schema_reader(surface:'both') owns the shared readsdescribe_object/list_objects/query_data;data_explorer/actions_executormarkedsurface:'ask'and stop dual-listing the shared reads.buildRegisterActivedegradation shim inagent-runtime.resolveActiveSkillshard-fails on incompatible skill↔agent surface (ADR-0064 §3);listAgentsfilters the catalog to platform agents only.Notes
main(theaskrename; the resolver was already skill-scoped — the "global fall-through" ADR-0064 describes was gone, only a stale comment remained). This PR finishes the rest.Acceptance tests (issue)
tools(ask)carries nocreate_*/*_metadata/blueprint tools.surface:'build'skill bound toaskis a load error;surface:'both'binds.Verified:
turbo run build(spec + service-ai DTS) green; 404/404 service-ai tests pass.🤖 Generated with Claude Code