Skip to content

test(lint): index the access-matrix rows once in the exhaustive fold case #22358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 8, 2026
Merged

test(lint): index the access-matrix rows once in the exhaustive fold case #22358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/lint/src/build-access-matrix.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,18 @@ describe('buildAccessMatrix CRUD columns — the spec fold, asked (#18785)', ()
permissions: entries.map((e, i) => ({ name: `ps_${String(i).padStart(4, '0')}`, objects: { o: e } })),
});
expect(m.entries.length).toBe(entries.length);
// Index the rows by permission set ONCE. A `find` per entry is quadratic —
// 3^8 entries make ~21.5M callbacks, each rebuilding the name — which ran
// this case past vitest's 5 s default on a loaded CI shard. First match
// wins, so every lookup returns the row `find` returned.
const rowByPermissionSet = new Map<string, (typeof m.entries)[number]>();
for (const e of m.entries) {
if (!rowByPermissionSet.has(e.permissionSet)) rowByPermissionSet.set(e.permissionSet, e);
}
const mismatches: string[] = [];
let cells = 0;
for (let i = 0; i < entries.length; i++) {
const row = m.entries.find((e) => e.permissionSet === `ps_${String(i).padStart(4, '0')}`)!;
const row = rowByPermissionSet.get(`ps_${String(i).padStart(4, '0')}`)!;
for (const verb of ['create', 'read', 'edit', 'delete'] as const) {
cells++;
if (row[verb] !== referenceFold(entries[i], verb)) {
Expand Down
Loading