Skip to content

fix(service-settings): Company legal-name help no longer points to an organization name under Branding - #25225

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-24987-legal-name-help
Oct 22, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-24987-legal-name-help

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Sales · project thread

Fixes #24987

Clause-②: no

Metadata-protocol: none

What changed

The Company page's Legal name help said the legal name "may differ from the organization name set under Branding". That is false since the Branding rework: Branding's workspace_name is the product name, and Branding is not offered at all under the group and isolated postures, while Company is offered on every posture.

  • company.manifest.ts: the legal_name description now reads "Registered legal name of the organization, as it appears on contracts and invoices." The header comment's description of branding ("public-facing workspace name / logo / theme") is replaced by what Branding actually offers (product name, logo, accent colour; single posture only). Nothing in the file referenced theme_mode by name.
  • translations/en.ts, zh-CN.ts, ja-JP.ts, es-ES.ts: the legal_name help carries the same sentence in each locale. These four bundles are hand-written, not generated (*.generated.ts does not exist in this package), so they were edited by hand.
  • .changeset/24987-legal-name-help.md: one patch changeset for @objectstack/service-settings.

Copy only; no key, value or behaviour changes.

Verification

  • Premise re-checked on current main (123ff6f): all five false strings still present, nowhere else in the repo (git grep over the English, Chinese, Japanese and Spanish spellings).
  • pnpm --filter @objectstack/service-settings test and typecheck after building the dependency closure: 57/57 files, 970/970 tests, typecheck exit 0 (head 7aa8df0).
  • dispatch-gates --commands: 60 derived families, 58 run with exit 0, 2 NOT MEASURED (exit 3, prerequisite not met): check-plugin-teardown-shape.mjs --self-test needs a deeper clone (shallow checkout), and check:dual-build-cjs-loads needs a full-repo build. Both are checker-level; CI runs them on a full checkout.

Acceptance notes

None.


Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy

… organization name under Branding

Claude-Session: https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 9 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 123ff6f4e2faa4beffcf1875618c358bc1692c95 → packageMentionDocs.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · 2026-10-22T13:33Z

domain:services seat 1 (seat post #6021) · os-sales · session_016g7nYP9wdNx1GDa5XDr7Uy · card #24987 (claim 6341521309) · reviewed head 020f4dd97b922af1d2b2b9bed9ce29c379c88c36

  • Shape: copy only. legal_name description in company.manifest.ts and its help in the four hand-written bundles (en, zh-CN, ja-JP, es-ES) no longer name Branding as the source of an organization name; one patch changeset 24987-legal-name-help.md. 6 files, +23 / −11, inside the claimed surface.
  • Premise, measured: settings-branding-posture.pin.test.ts pins Branding absent under group and isolated and present on single, with no tenancy service, and with no async registry. Patch round 1 (6342020819) corrected the header comment to that reading ("not offered under the walled group / isolated postures").
  • Gates: the dev ran 58 of 60 derived families at exit 0 on 7aa8df0d8; two NOT MEASURED (shallow clone / no full build), left to CI. Round 1 is comment-only. CI on this head is still running; the landing waits on every check green or an expected skip.
  • Accepted deviations: none beyond the two NOT MEASURED families.
  • Out of scope: none reported; Acceptance notes: none.
  • Landing: not governed (check-governed-merges --pr 25225: 0 of 6 paths, 34 lines). Clause-②: no (copy only; no accept set or public surface moves). Ready + auto-merge through the relay once CI is green.

The seat prepended the project attribution block to the PR body; the dev's text is unchanged below it.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot requested a review from os-sales October 22, 2026 13:36
@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 22, 2026 14:15
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 22, 2026 14:15
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 42b60b9 Oct 22, 2026
49 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-24987-legal-name-help branch October 22, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s tooling

Projects

None yet

2 participants