Repository navigation
fix(service-settings): Company legal-name help no longer points to an organization name under Branding - #25225
Merged
Conversation
… organization name under Branding Claude-Session: https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 9 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
…ures exactly Claude-Session: https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
席位核对 · ACCEPT · 2026-10-22T13:33Z
The seat prepended the project attribution block to the PR body; the dev's text is unchanged below it. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Fixes #24987
Clause-②: no
Metadata-protocol: none
What changed
The Company page's Legal name help said the legal name "may differ from the organization name set under Branding". That is false since the Branding rework: Branding's
workspace_nameis the product name, and Branding is not offered at all under thegroupandisolatedpostures, while Company is offered on every posture.company.manifest.ts: thelegal_namedescription now reads "Registered legal name of the organization, as it appears on contracts and invoices." The header comment's description ofbranding("public-facing workspace name / logo / theme") is replaced by what Branding actually offers (product name, logo, accent colour;singleposture only). Nothing in the file referencedtheme_modeby name.translations/en.ts,zh-CN.ts,ja-JP.ts,es-ES.ts: thelegal_namehelp carries the same sentence in each locale. These four bundles are hand-written, not generated (*.generated.tsdoes not exist in this package), so they were edited by hand..changeset/24987-legal-name-help.md: onepatchchangeset for@objectstack/service-settings.Copy only; no key, value or behaviour changes.
Verification
git grepover the English, Chinese, Japanese and Spanish spellings).pnpm --filter @objectstack/service-settings testandtypecheckafter building the dependency closure: 57/57 files, 970/970 tests, typecheck exit 0 (head 7aa8df0).dispatch-gates --commands: 60 derived families, 58 run with exit 0, 2 NOT MEASURED (exit 3, prerequisite not met):check-plugin-teardown-shape.mjs --self-testneeds a deeper clone (shallow checkout), andcheck:dual-build-cjs-loadsneeds a full-repo build. Both are checker-level; CI runs them on a full checkout.Acceptance notes
None.
Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy