Repository navigation
test(dogfood): give the single-posture default-organization beforeAll the sibling's 120 s boot budget - #25237
Merged
objectstack-fleet[bot] merged 1 commit intoOct 22, 2026
Conversation
… the sibling's 120 s boot budget The hook boots the full showcase and signs in on vitest's 10 s default hook budget; showcase-scope-depth gives the same boot 120_000. Claude-Session: https://claude.ai/code/session_01CxBKycaiUpA1yGx1XyoGqX Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对ACCEPT ·
Generated by Claude Code |
objectstack-fleet
Bot
deleted the
claude/issue-25195-dogfood-hook-budget
branch
October 22, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Fixes #25195
Clause-②: no
What
showcase-single-platform-insert-default-organization.dogfood.test.ts: thebeforeAllthat boots the full showcase (bootShowcase()), signs in and sends an invitation now passes an explicit hook budget of120_000as its second argument. That is the same budgetshowcase-scope-depth.dogfood.test.tsgives the same boot. One line changes:});becomes}, 120_000);.Why
The hook had no timeout argument, so vitest's 10 s default hook budget applied. Verified on
origin/main123ff6f4e:packages/qa/dogfood/vitest.config.tssets nohookTimeouton the root block or on either project (shared-showcase,isolated). The card recordsHook timed out in 10000msatbootShowcase()in two full batteries on a loaded box.afterAllis unchanged: the sibling'safterAll(async () => { await world?.stack?.stop(); })declares no budget either.Changeset
skip-changeset:@objectstack/dogfoodis"private": true, so this publishes nothing.Verification (head
d5dd966b7)pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2 test/showcase-single-platform-insert-default-organization.dogfood.test.ts(underos-verify-lock.sh):Test Files 1 passed (1),Tests 3 passed (3), Duration 27.94s; VERDICT command-exit 0. The 10 s red does not reproduce on an idle run, as the card notes, so this run shows the hook still passes. It does not show the old budget failing.pnpm --filter @objectstack/dogfood run typecheck(lock): VERDICT command-exit 0;tsc --listFilesOnlyincludes the changed file.pnpm lint(lock): VERDICT command-exit 0.dispatch-gates.mjs --commandsderived 56 commands, all exit 0.--ranprinted:56 derived famil(ies) accounted for — 56 run, 0 NOT-MEASURED (a DERIVED zero …). Three exited non-zero on the first pass because of the environment, then 0 on rerun:check-plugin-teardown-shape.mjs --self-testneeded its pinned fixture commit fetched into the shallow clone, andcheck:dts-closure/check:dual-build-cjs-loadsreaddist/while the closure build was still running.!and Clause-② has no(narrowing)arm.Acceptance notes
// test-budget:header grammar (scripts/measure-test-shard-timings.mjs) has no class for a real showcase boot, and the sibling declares none, so this PR adds none. It is out of this card's hook-only scope. Noted, not filed.Generated by Claude Code