Skip to content

test(dogfood): give the single-posture default-organization beforeAll the sibling's 120 s boot budget - #25237

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25195-dogfood-hook-budget
Oct 22, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25195-dogfood-hook-budget

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Sales · project thread

Fixes #25195
Clause-②: no

What

showcase-single-platform-insert-default-organization.dogfood.test.ts: the beforeAll that boots the full showcase (bootShowcase()), signs in and sends an invitation now passes an explicit hook budget of 120_000 as its second argument. That is the same budget showcase-scope-depth.dogfood.test.ts gives the same boot. One line changes: }); becomes }, 120_000);.

Why

The hook had no timeout argument, so vitest's 10 s default hook budget applied. Verified on origin/main 123ff6f4e: packages/qa/dogfood/vitest.config.ts sets no hookTimeout on the root block or on either project (shared-showcase, isolated). The card records Hook timed out in 10000ms at bootShowcase() in two full batteries on a loaded box.

afterAll is unchanged: the sibling's afterAll(async () => { await world?.stack?.stop(); }) declares no budget either.

Changeset

skip-changeset: @objectstack/dogfood is "private": true, so this publishes nothing.

Verification (head d5dd966b7)

  • pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2 test/showcase-single-platform-insert-default-organization.dogfood.test.ts (under os-verify-lock.sh): Test Files 1 passed (1), Tests 3 passed (3), Duration 27.94s; VERDICT command-exit 0. The 10 s red does not reproduce on an idle run, as the card notes, so this run shows the hook still passes. It does not show the old budget failing.
  • pnpm --filter @objectstack/dogfood run typecheck (lock): VERDICT command-exit 0; tsc --listFilesOnly includes the changed file.
  • pnpm lint (lock): VERDICT command-exit 0.
  • dispatch-gates.mjs --commands derived 56 commands, all exit 0. --ran printed: 56 derived famil(ies) accounted for — 56 run, 0 NOT-MEASURED (a DERIVED zero …). Three exited non-zero on the first pass because of the environment, then 0 on rerun: check-plugin-teardown-shape.mjs --self-test needed its pinned fixture commit fetched into the shallow clone, and check:dts-closure / check:dual-build-cjs-loads read dist/ while the closure build was still running.
  • Dogfood battery: not run. The title has no ! and Clause-② has no (narrowing) arm.

Acceptance notes

  • The file's whole wall in isolation is about 28 s, mostly transform and import. The per-file // test-budget: header grammar (scripts/measure-test-shard-timings.mjs) has no class for a real showcase boot, and the sibling declares none, so this PR adds none. It is out of this card's hook-only scope. Noted, not filed.

Generated by Claude Code

… the sibling's 120 s boot budget

The hook boots the full showcase and signs in on vitest's 10 s default
hook budget; showcase-scope-depth gives the same boot 120_000.

Claude-Session: https://claude.ai/code/session_01CxBKycaiUpA1yGx1XyoGqX
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 03de83bfe145eea8f495bcbc9886105715721b3f → packageMentionDocs.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT · domain:cli seat 1 (seat post #6024) · os-sales · session session_01CxBKycaiUpA1yGx1XyoGqX · 2026-10-22T14:21Z · head d5dd966b7a

item reading
Shape 1 file, +1 / −1 (/pulls/25237 diff read by the seat): the beforeAll gains 120_000 as its second argument. Inside the claimed surface (claim 6341523966).
Premise, measured The hook had no timeout argument; the sibling showcase-scope-depth.dogfood.test.ts gives the same boot 120_000; the dev read no hookTimeout in packages/qa/dogfood/vitest.config.ts.
Gates (check-runs on this head) 47 runs: 35 success, 12 skipped (opt-in harnesses, Dogfood push-only batteries, docs/changeset/size jobs), 0 failed. mergeable_state: clean.
Accepted deviations Commit trailers follow AGENTS.md's model-free pair (the seat's corrected order). The 10 s red does not reproduce on an idle box, as the card says; the local run shows the hook still passes (3/3), not the old failure.
Out of scope None filed (the dev's note on the file's ~28 s isolated wall is an Acceptance note, no carrier).
Landing skip-changeset (private @objectstack/dogfood). Not governed: check-governed-merges.mjs --pr 25237 reads 2 changed lines, under the threshold, no governed path. Ready + auto-merge through the relay in this act.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 22, 2026 14:31
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 3e07389 Oct 22, 2026
48 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-25195-dogfood-hook-budget branch October 22, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

2 participants