Repository navigation
docs: retire legacy UI-hint keys (ADR-0085 semantic roles) - #2529
Merged
Merged
Conversation
Sweep hand-written docs and skills for teachings of the object UI-hint
keys ADR-0085 removed/renamed, and rewrite them to the current
semantic-role protocol (nameField / highlightFields / stageField /
fieldGroups + Field.group, per-page customization via an assigned Page):
- content/docs/guides/data-modeling.mdx: fieldGroups example + property
table taught the removed ObjectFieldGroup.visibleOn and the deprecated
defaultExpanded flag; now teach the collapse enum
('none'|'expanded'|'collapsed') and drop group-level visibleOn.
- content/docs/guides/public-forms.mdx: section 10 taught the removed
(never-implemented) ObjectSchema.defaultDetailForm binding and the
retired views.formViews/views.form resolution chain; rewritten to
explain record detail is derived from the semantic roles, with an
assigned Page as the per-page customization path. Frontmatter
description updated accordingly.
- skills/objectstack-data/SKILL.md: fieldGroups example modernized
(collapse instead of defaultExpanded; group visibleOn removed) and the
group-property bullet now teaches the collapse enum.
- skills/objectstack-ui/SKILL.md: detail.relatedLayout ('stack'|'tabs')
teaching removed with the whole detail:{...} block; now teaches the
default single Related tab + custom record Page (record:related_list)
for first-class child-table navigation.
- skills/objectstack-formula/SKILL.md: dropped the
ObjectFieldGroup.visibleOn row from the CEL-surface inventory (the key
was removed per ADR-0085 / ADR-0049 enforce-or-remove).
ADRs, changelogs/changesets, audits, and auto-generated references
(content/docs/references/**, skills/objectstack-ui/references/
react-blocks.md) are deliberately untouched.
Verified: check:doc-authoring clean; docs:build green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added a commit
that referenced
this pull request
Jul 3, 2026
…ailForm JSDoc (ADR-0085 remnants) (#2530) Follow-up to the ADR-0085 hand-written docs sweep (#2529) — these two remnants live in code and regenerate into docs: - RecordDetailsProps layout/fields descriptions taught the deprecated compactLayout name; now teach the canonical highlightFields (compactLayout remains a supported alias). Regenerated react-blocks contract + reference md. - Removed an orphaned JSDoc block for defaultDetailForm in object.zod.ts — the prop was never implemented and was removed from the spec in #2402. Doc-text only; no schema shape or behavior change. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only sweep for teachings of the object UI-hint keys that ADR-0085 removed or renamed, rewritten to the current semantic-role protocol (
nameField/highlightFields/stageField/fieldGroups+Field.group; per-page customization via an assigned Page). Executes the "Docs and skills … are updated in the same change series" item from ADR-0085 §Execution.Files touched
content/docs/guides/data-modeling.mdx— the Field Groups example and theObjectFieldGroupproperty table taught the removed group-levelvisibleOnand the deprecateddefaultExpandedflag. Now teach thecollapseenum ('none' | 'expanded' | 'collapsed', with a note thatdefaultExpandedis a deprecated alias) and point per-page needs at an assigned Page.content/docs/guides/public-forms.mdx— §10 taughtObjectSchema.defaultDetailFormand aviews.formViews/views.formresolution chain.defaultDetailFormwas never implemented and was removed from spec in the dead-props batch (feat(spec): remove first batch of dead metadata props (#2377, A2) #2402); object-levelviews.*hints were retired by ADR-0085. The section now explains that record detail derives from the semantic roles, with an assigned Page schema as the supported per-page path. Frontmatter description updated to match.skills/objectstack-data/SKILL.md— fieldGroups example modernized (collapse: 'collapsed'instead ofdefaultExpanded: false; removed the groupvisibleOnline) and the group bullets now teach thecollapseenum + assigned-Page guidance.skills/objectstack-ui/SKILL.md— removed thedetail.relatedLayout('stack' | 'tabs') teaching (the whole object-leveldetail: {...}block is gone). Now teaches: single Related tab is the built-in layout; first-class child-table navigation = a custom record Page withrecord:related_listblocks; relationship-level refinements (relatedList: false,relatedListTitle/relatedListColumns) remain.skills/objectstack-formula/SKILL.md— dropped theObjectFieldGroup | visibleOnrow from the CEL-surface inventory (key removed per ADR-0085 / ADR-0049 enforce-or-remove).Deliberately untouched
docs/adr/**— historical records, never rewritten..changeset/**— historical.docs/audits/2026-06-objectschema-property-liveness.md(and the dead-surface disposition plan) — point-in-time audit snapshots; they document the legacy keys, they don't teach them.content/docs/references/**(ui/component.mdx,ui/view.mdx,studio/object-designer.mdx) — auto-generated from spec (build-docs.ts); theirdefaultExpanded/defaultExpandedDepthhits belong to unrelated Studio-designer / tree-view config schemas, notObjectFieldGroup.skills/objectstack-ui/references/react-blocks.md— generated frompackages/spec/src/ui/react-blocks.ts; its two stalecompactLayoutprop-description mentions live in that source file (code, out of scope for a docs sweep — noted as follow-up).Verification
pnpm check:doc-authoring— clean (171 files, no bare metadata literals).pnpm docs:build— green. (The build locally regeneratedcontent/docs/references/**with unrelated pre-existing drift vs. current spec; that churn was reverted, not committed.)docs/**,content/**,skills/**,packages/*/README.md,examples/**— remaining hits are only ADRs, audits, changelogs, generated references, and the new "deprecated alias" notes themselves.🤖 Generated with Claude Code