Repository navigation
test(cli): move the audit-mail-bodies archive test budget onto the 10 s grid - #25492
Merged
Merged
Conversation
… s grid The header declared `test-budget: 85`, which the shard-timings generator's declaration reader refuses (the budget must be a multiple of 10). The line's own arithmetic, 67.8 s x 1.25 = 84.75 s, rounds up to 90 on the grid. Class and reason are unchanged. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对 · ACCEPT · 2026-10-23T16:13Z
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Part of #25411
Clause-②: no
Metadata-protocol: none
What changed
packages/cli/src/commands/migrate/audit-mail-bodies.archive.integration.test.tsline 2 declared// test-budget: 85 — spawns the real producer once per single-cause fixture: …. The weeklyshard-timings-refreshgenerator reads that line withreadTestBudgetinscripts/measure-test-shard-timings.mjsand refuses it, because SECONDS must be a multiple of 10 (the reading xCEILING_HEADROOM, rounded UP to the next 10 s).The line's own arithmetic is 67.8 s x 1.25 = 84.75 s, which rounds up to 90. Only the number moves: the class (one of
TEST_BUDGET_CLASSES) and the reason are unchanged, and the reason stays true because its arithmetic did not change.Scope is producer 1 only, the file the claim names. Producer 2, a PR-time grid check in
scripts/, belongs todomain:devxand is not taken here. #25411's second producer remains open for that lane.Evidence
readTestBudgetfromscripts/measure-test-shard-timings.mjson both versions:{"seconds":90,"cls":"spawns the real producer once per single-cause fixture","line":2}.b2c0752900: refused,…audit-mail-bodies.archive.integration.test.ts:2: the budget 85 s is not on the 10 s grid.test[-_ ]?budget:(24 files) was fed toreadTestBudget.b2c0752900: exactly 1 refused, this line. No other off-grid or ungrammaticaltest-budget:line exists in the tree.os-verify-lock:pnpm --filter @objectstack/cli exec vitest run --project integration --maxWorkers=2 src/commands/migrate/audit-mail-bodies.archive.integration.test.tsgave Test Files 1 passed, Tests 8 passed, Duration 43.77 s, VERDICT command-exit 0. That is inside the declared 90 s, on a shared container.pnpm --filter @objectstack/cli exec vitest run --project unit --maxWorkers=2gave Test Files 326 passed (326), Tests 4805 passed (4805), VERDICT command-exit 0.node scripts/pm/dispatch-gates.mjs --commands, at head6d1e8648c3): 56 commands. 54 exited 0.pnpm check:dual-build-cjs-loadsandpnpm check:i18n-coverageexited 3 (PREREQUISITE NOT MET: they read built output of packages outside the cli closure).--ranreconciles: 56 derived, 54 run, 2 NOT-MEASURED, 0 UNRUN. CI measures both on a full build.Changeset
None. This follows AGENTS.md Post-Task Checklist step 3:
skip-changesetis for a diff that publishes nothing from any released package. The shipped contents of@objectstack/cliare itsfiles[]:dist,README.md,CHANGELOG.md. Afterpnpm --filter '@objectstack/cli...' build:describetitle have 0 hits in those paths.audit-mail-bodies.ts's docblock (2 files indist) and its help example (3 hits indist/commands/migrate/audit-mail-bodies.js).Acceptance notes
🤖 Generated with Claude Code
https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy