Repository navigation
fix(setup): relabel the sys_position nav entry to Positions (ADR-0090 D3 vocabulary) - #2762
Merged
Merged
Conversation
… D3 vocabulary) The Setup app's Access Control group still showed 'Roles' (nav_roles) for the sys_position object list — a leftover of the P1 rename wave that the P3 sweep missed because navigationContributions live in security-plugin.ts, not in the objects/ directory. Renames the nav id to nav_positions, fixes the label and all four locale translations, updates the spec app.test fixture and stale comments in setup-nav.contributions.ts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 3 package(s): 95 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 10, 2026 09:23
This was referenced Aug 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while answering "does Setup have management UI for assignments": the Setup app's Access Control group still shows "Roles" for the
sys_positionobject list — a leftover of the ADR-0090 P1 rename that the P3 vocabulary sweep missed (the nav lives insecurity-plugin.ts'snavigationContributions, not in theobjects/directory the sweep covered). The object pointer itself was already correct (sys_position), so this is a label/id fix, not a dead link.nav_roles→nav_positions; labelRoles→Positions(plugin-security/src/security-plugin.ts)角色→岗位, ja-JPロール→ポジション, es-ESRoles→Posiciones, enRoles→Positions(platform-objects/src/apps/translations/*)Roles / Permission Setscomments insetup-nav.contributions.tsand thespecapp.test fixture aligned to the frozen vocabularyVerification
pnpm turbo build --filter=@objectstack/plugin-security --filter=@objectstack/platform-objectsgreenpackages/specsrc/ui/app.test.ts62/62🤖 Generated with Claude Code
https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
Generated by Claude Code