Skip to content

[WIP] Update home page version number to match @objectstack/spec #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 3 commits into from
Jan 27, 2026
Merged

[WIP] Update home page version number to match @objectstack/spec #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e62f37
Initial plan
Copilot Jan 27, 2026
f331589
Update homepage version to dynamically use @objectstack/spec version
Copilot Jan 27, 2026
95e4752
Optimize version loading to use constant instead of function
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/docs/lib/homepage-i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Supports: en (English), cn (Chinese/中文)
*/

import { SPEC_VERSION } from './version';

export interface HomepageTranslations {
// Hero Section
badge: {
Expand Down Expand Up @@ -86,7 +88,7 @@ export interface HomepageTranslations {
export const en: HomepageTranslations = {
badge: {
status: 'Protocol Specification',
version: 'v0.3.3 (Draft)',
version: SPEC_VERSION,
},
hero: {
title: {
Expand Down Expand Up @@ -157,7 +159,7 @@ export const en: HomepageTranslations = {
export const cn: HomepageTranslations = {
badge: {
status: '协议规范',
version: 'v1.0',
version: SPEC_VERSION,
},
hero: {
title: {
Expand Down
13 changes: 13 additions & 0 deletions apps/docs/lib/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* Version utilities
*
* Import the version number from @objectstack/spec package
*/

import specPackage from '../../../packages/spec/package.json';

/**
* The current version of @objectstack/spec
* Computed once at module initialization
*/
export const SPEC_VERSION = `v${specPackage.version}`;
Comment on lines +7 to +13

Copilot AI Jan 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing packages/spec/package.json via a deep relative path hard-codes the monorepo layout and reaches across package boundaries. Consider switching to reading the installed workspace package (e.g., add @objectstack/spec as a dependency and resolve its package root at runtime/build-time) or exposing a version export from @objectstack/spec, so apps/docs doesn’t depend on ../../../packages/... paths.

Copilot uses AI. Check for mistakes.
Loading