Repository navigation
fix(severity): use saved scan context for helper selection - #1815
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4654202107
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
alandelong-oai
left a comment
There was a problem hiding this comment.
The saved-scan helper context is carried through lookup and severity persistence, but the existing timestamp-precision finding remains material. I independently reproduced latest selecting the older of two scans updated within one millisecond. The shared selector also changes dedupe --scan latest, which previously preserved that ordering for normal UTC timestamps. Please retain sub-millisecond ordering before merging.
Types, formatting, and the plugin build passed. A direct selector probe verified the offset/fractional-second fixes and reproduced the precision regression. The focused suite had 14 passes and 69 failures at the existing fixture ownership guard; full SDK runs were not repeated under that limitation.
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks—no blocking findings in this re-review. The timestamp-precision issue is fixed: saved-scan selection preserves microseconds, offsets and deterministic ties while retaining the intended helper protections.
Validation passed 30 focused tests, 68 real SQLite selector cases, SDK/default CLI helper-rejection probes, types, formatting, and fresh package/archive checks. The previous head still fails the independent microsecond reproduction; this head passes. Full saved-scan persistence and broad SDK suites remain limited by the unchanged fixture ownership restriction; hosted CI is still running.
Summary
Saved-scan severity classification now resolves the selected repository before choosing helper executables and carries its protected paths through assessment persistence. Selecting
latestpreserves chronological ordering across timestamp offsets and sub-millisecond differences.Changes
Testing
1319506487.pnpm pack, including prepack builds, and the existing archive checker passed; 630 archive entries validated.12345and694279854: each had 5,527 passes, 81 skips, and 13 failures. Both runs failed. Every complete failure diagnostic matched a fresh baseline control, with no unclassified failures.efdc65a(observed 2026-10-20 at 09:33 UTC).Risk and rollout
Uses existing CLI arguments and saved-scan formats. Feedback selection, custom history runners, and direct-directory classification retain their existing behavior. Saved classification continues to support removed repository directories.
Public disclosure review