osquery can't close win pipe #57

Activity

1. muffins

   added

   bug

   Windows

   on Jul 13, 2018
2. blessedvictim

   closed this as completedon Apr 29, 2019
3. JarryShaw commented on Aug 10, 2019

   

   JarryShaw

   on Aug 10, 2019

   Contributor

   More actions

   This issue remains on version 3.0.6. I used del (calling __del__ internally) to make a more reasonable pipe closing, since there's no close function.

   >>> import osquery
   >>> instance = osquery.SpawnInstance()
   >>> instance.open()
   >>> del instance
   Exception ignored in: <function SpawnInstance.__del__ at 0x000000D3ABF62678>
   Traceback (most recent call last):
     File "C:\Users\fakepath\AppData\Local\Programs\Python\Python37\lib\site-packages\osquery\management.py", line 89, in __del__
       self.connection.close()
     File "C:\Users\fakepath\AppData\Local\Programs\Python\Python37\lib\site-packages\osquery\extension_client.py", line 55, in close
       self._transport.close()
     File "C:\Users\fakepath\AppData\Local\Programs\Python\Python37\lib\site-packages\thrift\transport\TTransport.py", line 156, in close
       return self.__trans.close()
     File "C:\Users\fakepath\AppData\Local\Programs\Python\Python37\lib\site-packages\osquery\TPipe.py", line 35, in close
       win32pipe.DisconnectNamedPipe(self._handle)
   pywintypes.error: (1, 'DisconnectNamedPipe', 'Incorrect function.')
   

   Environment:

   • Windows 10 Pro
   • osquery-python: 3.0.6
   • ossuary: 3.3.0
   • pywin32: 224
4. theopolis

   reopened this on Aug 16, 2019
5. outhex

   added a commit that references this issue on Jun 18, 2021

   Update TPipe.py to replace win32pipe.DisconnectNamedPipe with win32fi…

   ...

   19691b9
6. blessedvictim

   closed this as completedon Sep 1, 2021
7. hotab commented on Dec 23, 2022

   

   hotab

   on Dec 23, 2022

   Last edited by hotab

   More actions

   This still happens in 3.0.7 (latest version from pip) on win 10

   Problem disappears when using outhex@19691b9 - this fix

   👍React with 👍1Reacted by Enrique S. Filiage
8. hotab

   added a commit that references this issue on Dec 23, 2022

   Fix 2 issues

   ...

   37cff7a
9. filiagees commented on Apr 10, 2024

   

   filiagees

   on Apr 10, 2024

   Last edited by filiagees

   More actions

   This still happens in 3.0.7 (latest version from pip) on win 10

   Problem disappears when using outhex@19691b9 - this fix

   @hotab This fix worked for me, too.
   Thanks for pointing out.

   I'm using win10, with:

   • osquery==3.0.7
   • pywin32==306
   • pywin32-ctypes==0.2.2