Repository navigation
Conversation
The hidden 3D pane had display none, so its canvas had no size and the scene, with the door and window tools, never mounted until 3D was shown once. The 2D plan sends its wall events to those tools, so placing an opening in 2D-only view showed only the cursor chip and a click placed nothing. The pane now keeps its size while hidden and paused.
2 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In 2D-only view the hidden 3D pane had
display: none, so its canvas had no size and the scene never mounted, and with it the door and window tools. The 2D plan sends itswall:*events to those tools, so placing a door or window in 2D-only view just showed the cursor chip and the click placed nothing, until 3D was opened at least once. The hidden pane now keeps its size (visibility: hidden, no pointer events, render still paused), so the tools are there from the first hover.Side effect worth knowing: since the 3D camera now mounts in 2D-only view too, the plan opens aligned to the camera like it already did after visiting 3D once.
How to test
Screenshots / screen recording
Before (fresh 2D-only load, Door on a wall, only the chip):
After:
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Localized layout/CSS change in the editor viewer grid with clear accessibility handling; main tradeoff is slightly more 3D initialization work in 2D-only view while render stays paused.
Overview
Fixes door and window placement in 2D-only view by changing how the always-mounted 3D viewer is hidden when no 3D pane is active.
Instead of
display: none(which collapsed the canvas to zero size and prevented the scene andToolManagerfrom mounting), the hidden 3D pane now usesvisibility: hiddenwithpointer-events: nonewhile still occupying the grid cell, so WebGL context is preserved and placement tools are available for 2Dwall:*events from the first load.aria-hiddenis set when the 3D pane is not shown.Side effect: the 3D camera now initializes in 2D-only mode too, so the floor plan opens aligned to the camera without needing to open 3D first. Rendering remains paused via existing
renderPaused={!show3d && !showLoader}.Reviewed by Cursor Bugbot for commit 4d01b57. Bugbot is set up for automated code reviews on this repo. Configure here.