Repository navigation
Conversation
lazerg
requested review from
SakiTakamachi,
bukka and
kamil-tekiela
as code owners
October 23, 2026 17:52
Member
|
Can this not be tested with a real server? |
Contributor
Author
|
A real server does hit this path (any plain OK reply, like an INSERT), so existing mysqli tests already cover it and would fail on an x32 build. But on 64-bit they pass with or without the fix, so I can't make a real-server test that fails before the fix. The fake server just lets me pin the exact packet. |
Member
|
So we don't need any new test. The problem wasn't a missing test, but not running it under that specific setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_mysqlnd_rset_header_read() stored the zend_ulong from php_mysqlnd_net_field_length() in a size_t. On x32 that is 32 bits, so MYSQLND_INVALID_NET_FIELD_LENGTH was truncated and a minimal OK packet was rejected as an over-read. Making the variable a zend_ulong fixes it.
Fixes GH-24609