Skip to content

Add parsing of CASE Expressions - #88

Merged
nijel merged 5 commits into
phpmyadmin:masterfrom
devenbansod:fix_pma_12100
Oct 3, 2016
Merged

nijel merged 5 commits into
phpmyadmin:masterfrom
devenbansod:fix_pma_12100

Conversation

@devenbansod

@devenbansod devenbansod commented Sep 25, 2016 •

Copy link
Copy Markdown
Member

Fix phpmyadmin/phpmyadmin#12100.
Also see my comment at phpmyadmin/phpmyadmin#12100 (comment)

Tests to be added.

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

Fix phpmyadmin/phpmyadmin#12100

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov-io

codecov-io commented Sep 25, 2016 •

Copy link
Copy Markdown

Current coverage is 99.42% (diff: 100%)

Merging #88 into master will increase coverage by 0.02%

@@             master        #88   diff @@
==========================================
  Files            51         52     +1   
  Lines          3337       3456   +119   
  Methods         171        174     +3   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3317       3436   +119   
  Misses           20         20          
  Partials          0          0          

Powered by Codecov. Last update c66456f...f151567

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod
devenbansod force-pushed the fix_pma_12100 branch 3 times, most recently from 46bfa6f to f151567 Compare September 26, 2016 14:25
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod

Copy link
Copy Markdown
Member Author

This seems ready to tested and hopefully merged.

@nijel nijel self-assigned this Oct 3, 2016
@nijel
nijel merged commit 2608760 into phpmyadmin:master Oct 3, 2016
@nijel

nijel commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

Indeed it looks good!

nijel added a commit that referenced this pull request Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this pull request Oct 3, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

nijel commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

I've added changelog entry (in e2144e7) and adjusted license header (in 1b72bd3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants