Repository navigation
fix(EffectGroup): use the EffectComposer's camera and scene - #397
Merged
kvvasuu merged 1 commit intoOct 20, 2026
Merged
Conversation
Co-authored-by: Rahul Kashyap <itisrmk@users.noreply.github.com>
Contributor
Author
|
Hi! Could a maintainer approve the CI workflows for this PR when you have a moment? Thanks. |
Collaborator
|
@itisrmk Thanks. I鈥檒l review in a few hours. |
kvvasuu
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EffectGroupcreates itsEffectPassonce and keeps it across rebuilds.EffectPassonly reads the camera's near/far (and handsmainCamera/mainSceneto its effects) when it's set up, so when theEffectComposer'scameraorscenechanges, the composer's own passes get the new camera but the group's pass keeps the old one. Depth-based effects inside an<EffectGroup>then keep using stalecameraNear/cameraFar.This is the same kind of problem #396 fixed for N8AO.
How
EffectGroupnow readsscenefromEffectComposerContextalongsidecamera, and a layout effect assignspass.mainCameraandpass.mainScenewhenever the pass, camera, or scene changes. The pass itself isn't rebuilt.Tests
Added a test in
src/tests/EffectGroup.test.tsxthat renders a group under one camera, switches the composer to a camera with different near/far, and checks that the same pass now carries the new values. Lint, typecheck, tests, and build pass locally.