Skip to content

move comment before #776

Open
Open

Description

@xenoterracide

given

    <module name="IllegalImport" /><!-- defaults to sun.* packages -->

I would like the reformat to be

    <!-- defaults to sun.* packages -->
    <module name="IllegalImport" />

instead of

    <module name="IllegalImport" />
    <!-- defaults to sun.* packages -->

note: obviously I've turned off whitespace sensitivity.

I feel like this would be a sensible default with whitespace sensitivity turned off, but an option would be nice too. I feel like programming convention is, comments to the right affect code to the left. Comments before affect code below. So moving the comment to be after changes the ... semantics.

Alternative, or maybe in addition to, if you could leave the comment alone if it's not making the line too long.

Activity

  1. fbridault commented on Apr 23, 2024

    @fbridault

    I would also love that...

    Even better, if I could make a wish, ideally, by default, move it on top and optionally, preserve it as it is.

  2. kddnewton commented on Apr 23, 2024

    @kddnewton
    Member

    I'm not going to make a configuration option for this, but I am open to changing the default behavior here. Are we okay with saying that:

    <foo /><!-- bar -->

    gets reformatted to:

    <!-- bar -->
    <foo />

    but

    <foo /> <!-- bar -->

    stays the same? As in, they have to be "touching" in order to get this special behavior?

  3. fbridault commented on Apr 23, 2024

    @fbridault

    Thank you for your answer.
    Yes, for me that would look perfectly acceptable!

  4. xenoterracide commented on Apr 23, 2024

    @xenoterracide
    Author

    Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions