Repository navigation
Update contributions.yaml - #68
Conversation
Fixing dead links (mainly by adding mailto: to mail address)
✅ Deploy Preview for processing-contributions ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @twisst , thanks for your work on this. I'm happy to merge this in, but as stated in the issue in the processing-website repo, this isn't a permanent solution. You've already done a lot for the issue, but would you be interested in taking a look at the script that makes the jsons? it is currently written in python, and is this file: https://github.com/processing/processing-contributions/blob/main/scripts/to_sources_jsons.py |
|
Hi @mingness, the changes in this commit would go into the json's without changes to the conversion script. so that's separate from the conversion problems I mentioned in the issue. So you could just merge these changes as that is already a small improvement :-) |
|
@mingness hang on, I get it now, contributions.yaml is also being recreated from other sources. That means the 'mailto:' needs to be added in either the script that updates contributions.yaml or in the script that makes the JSONs. It's just four broken links in this case or something, it's probably not worth the trouble :-) |
|
@twisst that's right, the contributions.yaml will get updated from the library properties files, so that's why it's not a permanent solution, and a more long term solution would be to update the script that converts the yaml file to the jsons. No worries, I'll merge this, and it will solve the issues for now. |
fixes processing/processing-website#595 or at least the dead links that are in processing-contributions (mainly by adding mailto: to mail addresses)