Skip to content

Add Unit Tests for handling key events in processing:core #965

Closed

Description

@Rishab87

I saw a few open issues related to key events not behaving as expected. It would make sense to add unit tests for handling key events to ensure these events work as expected. The tests should cover all possible cases, especially those mentioned in the existing issues.

Activity

  1. SableRaf commented on Mar 8, 2025

    @SableRaf
    Collaborator

    Thanks for opening this @Rishab87.

    Which existing issues are you referring to?

  2. Rishab87 commented on Mar 8, 2025

    @Rishab87
    ContributorAuthor

    I'm referring to issues like #779

  3. Rishab87 commented on Mar 8, 2025

    @Rishab87
    ContributorAuthor

    I've also created a PR for this issue, can you please review it?

  4. Rishab87 commented on Mar 19, 2025

    @Rishab87
    ContributorAuthor

    Hi @SableRaf, just a follow up, since this is done, so should I start adding other unit tests too?

  5. SableRaf commented on Mar 19, 2025

    @SableRaf
    Collaborator

    Hi @Rishab87. Yes, go ahead!

    Please open a new PR since the first one already got approved for the 4.4.1 milestone.

    Thank you for your contributions 💙

  6. Rishab87 commented on Mar 20, 2025

    @Rishab87
    ContributorAuthor

    Yes I'll open a seperate issue and a PR which can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions