Repository navigation
Conversation
…read No test read a valid header with FHCRC, which _GzipReader checks: the headers() helper lost its only test in 2c4de51. test_seek reads before it seeks from the end, so seek() never had to find the size.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two paths in the C code of
_GzipReaderhave no test:FHCRC)._GzipReaderchecks this CRC, andgzipdoes not. Theheaders()helper intests/test_igzip.pybuilds such headers, but no test has used it since 2c4de51 removedtest_read_gzip_header_positiontogether with the Python header parser.seek()call from the end while the size is not known yet, which makesseek()decompress all of the data first.test_seekreads before it seeks from the end, and that read reaches the end of its 4,000 bytes, so the size is already known.The new tests read each header from
headers()and seek from the end of a fresh file. Both pass ondevelop.This PR changes only tests, so it has no CHANGELOG entry.
Checklist