Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2057.
I reproduced the warning in #2057 by changing a loaded cargo row's owner. SQLAlchemy synchronizes its
fitIDduring flush, which invokes the column listener and changes a previously clean fit's modification time too late to persist it.I exclude
fitIDfrom the column listeners. Fit collection listeners still track additions and removals, and ordinary cargo edits still update the fit's timestamp.The regression test fails with the reported warning before the fix and passes afterward.
Regression test:
tests/test_modules/test_eos/test_saveddata/test_events.py(fails before the fix, passes after).This pull request was prepared with an AI coding assistant (OpenAI Codex driven by a verification harness) and reviewed by a person before it was opened. The regression test was checked to fail on the current code by an assertion and to pass with the fix 5/5 times in a row.