Repository navigation
Support path-like filenames when adding pictures - #1629
Open
LaoChouPro wants to merge 1 commit into
Open
LaoChouPro wants to merge 1 commit into
LaoChouPro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a pathlib.Path to add_picture currently treats it as a file-like object and fails on seek(). This accepts path-like filenames in the image loader and updates the related type annotations. Fixes #1544.
The tests cover string and Path inputs, both picture insertion methods, and saving and reopening a document with a Unicode image filename. All 1612 tests pass with pytest 8.4.2 and pyparsing 3.2.3, and both package builds pass. Pyright still reports the same two errors on the unchanged baseline.