Repository navigation
[UI] added trim option - #47
Merged
Merged
Conversation
Thalmann
reviewed
Jun 1, 2017
| source_in_sink = lattice.in_constraint(source.cfg_node, sink.cfg_node) | ||
|
|
||
| secondary_in_sink = [] | ||
| secondary_in_sink = list() |
Contributor
|
Looks good :) I shortly glimpsed over the additions, what is the idea with the evil_node and what is its purpose? |
Collaborator
Author
|
Good catch, I couldn't really think of a good name for it. I hope this commit makes it more clear bd33820. That location is where we step backwards and find the nodes to add to the trimmed list. I can't think of a good one-size-fits-all variable name so I did |
Collaborator
Author
|
Going to make a blackbox PR that depends on this code, to deal with #45. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #46. Let me know what you think @Thalmann.