Repository navigation
Another blackbox calls PR + interprocedural documentation and cleanup - #63
Merged
Merged
Conversation
…ll_index into a stack and (b) OR (or add) all ret values to OR taint
…nse(html.replace('{{ param }}', param)) are both popping
KevinHock
commented
Sep 7, 2017
| return_value_of_nested_call = self.visit(call_arg) | ||
| if return_value_of_nested_call in self.blackbox_calls: | ||
| logger.debug("[Little collins] nested blackbox call, ouchie") | ||
| raise |
Collaborator
Author
There was a problem hiding this comment.
Wait what, there's no test for nested blackbox calls? Make one if not.
KevinHock
commented
Sep 7, 2017
| def_node.lineno, | ||
| saved_function_call_index) | ||
| function_nodes = self.visit_and_get_function_nodes(definition) | ||
| self.filenames.pop() # Should really probably move after restore_saved_local_scope!!! |
Collaborator
Author
There was a problem hiding this comment.
Investigate this or just be lazy and make a GitHub issue for it.
Collaborator
Author
There was a problem hiding this comment.
(Just looking to document the code that triggers the bug.)
KevinHock
commented
Sep 7, 2017
|
|
||
| return self.add_builtin(node) | ||
|
|
||
| def add_class(self, call_node, def_node): |
Collaborator
Author
There was a problem hiding this comment.
This was dead-code, but we should figure out where we're at with class support and write more tests.
KevinHock
commented
Sep 7, 2017
| @@ -1,3 +1,4 @@ | |||
| """FILL ME IN""" | |||
Collaborator
Author
There was a problem hiding this comment.
Maybe just add an e.g. for sample input and output from the tests.
… to remove the results file
…did some weird but necessary stuff
…and I didn't change anything after I wrote the test :)
Collaborator
Author
|
Boom. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix #45 but leaves out the 'ask the user' part for the mapping for another PR. (Mapping here being, "Hey I noticed you called
scrypt.encryptwith the 1st arg tainted, does it return a tainted value? Yes/No" with a future improvement of "what sinks are it tainted for?" e.g. SQL not XSS.PR almost done, I just need to add traversing keyword_args, adjusting remaining tests and of course cleanup.