Repository navigation
Add missing ISO alphabetic country codes - #539
Open
Plastic-time wants to merge 1 commit into
Open
Plastic-time wants to merge 1 commit into
Plastic-time wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
country_code("728", iso_format="numeric")succeeds, but the correspondingSSandSSDcodes fail. Eight countries/territories already present in the numeric set are missing from the alphabetic mapping.Add AX/ALA, BQ/BES, BL/BLM, CI/CIV, CW/CUW, MF/MAF, SS/SSD and SX/SXM. The mappings were checked against the ISO country-code table published with OASIS UBL and the UN Statistics Division country list.
Tests cover explicit and automatic format selection, case-insensitive acceptance, and the existing rejection of lowercase codes by default. All eight regression cases fail before the change; the full suite passes afterward (1,524 tests on Python 3.12). Ruff lint/format, Pyright and Bandit checks pass.