Repository navigation
Accept current SLE, XCG and ZWG currency codes - #542
Open
mjanthony819 wants to merge 2 commits into
Open
mjanthony819 wants to merge 2 commits into
mjanthony819 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currency() rejects SLE (Sierra Leone's leone), XCG (Caribbean guilder) and ZWG (Zimbabwe Gold), although all three are in the current ISO 4217 list published by SIX, the maintenance agency.
Add those three codes without removing any previously accepted codes. The regression tests cover the symbol flag, case-sensitive and ignore_case behavior, and continued acceptance of SLL, ANG and ZWL.
Source: https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-one.xml (published 2026-09-17).
Nine new cases fail before the change. With the change, all 1,528 tests pass on Python 3.12, including the configured doctests. Repository-wide Ruff lint and formatting checks pass. Strict Pyright passes with the test environment selected explicitly.
This is a targeted addition of three circulating-currency codes, not a full refresh of fund, metal or historical codes. AI assistance covered research, implementation, tests and this description.