You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I love working on unit-tests in CPython, but I have a small problem. When I submit a PR the CI is usually red, because NEWS check fails: there's no NEWS entry.
Most of the reviewers say that test-only changes should not go to NEWS (and I agree). But, right now the only way for non-members is to wait for someone who will put skip-news badge manually to turn the CI to be green. I don't think that precious time should be spent on that! 🙂
Otherwise, it is less-likely to get a review (because PR has this red cross as its status, some people might think that something is broken).
For new contributors this might be even more problematic.
IMHO the opt-out model we currently have works well enough and makes the check more predictable. We could add custom rules for docs or tests, but they would have to be documented and there are cases where a NEWS entry is still required.
Activity
corona10 commentedon Jan 8, 2022
kumaraditya303 commentedon Jan 9, 2022
In my experience,
skip-newslabel should also be added totype-documentationPRs as generally docs PRs don't require a news fragment.isidentical commentedon Jan 9, 2022
Please see #363 for the previous discussion in this matter.
ezio-melotti commentedon Jun 5, 2022
IMHO the opt-out model we currently have works well enough and makes the check more predictable. We could add custom rules for docs or tests, but they would have to be documented and there are cases where a NEWS entry is still required.
DanielNoord commentedon Jul 14, 2022
skip newsis now automatically applied to all PRs that only have adocslabel and don't already have a news item attached.We could also implement this for the
testslabel. Is this something we want to do? If so you can assign me and I'll prepare a PR.ezio-melotti commentedon Jul 15, 2022
This might come in handy for python/cpython#94808
AA-Turner commentedon Aug 12, 2025
Closing, stale.
hugovk commentedon Oct 18, 2025
See also issue python/bedevere#669 and PR python/bedevere#670.