Skip to content

Curses Menu #44985

Open
Open

Description

@ffrederick
BPO 1723038
Nosy @amauryfa, @serhiy-storchaka, @madebr
PRs
  • bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails #21933
  • Files
  • cursesmenu.diff: cursesmenupatch1
  • curses_menu.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = None
    created_at = <Date 2007-05-21.21:00:33.000>
    labels = ['extension-modules', 'type-feature', '3.7']
    title = 'Curses Menu'
    updated_at = <Date 2020-08-21.03:42:56.509>
    user = 'https://bugs.python.org/ffrederick'

    bugs.python.org fields:

    activity = <Date 2020-08-21.03:42:56.509>
    actor = 'maarten'
    assignee = 'serhiy.storchaka'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2007-05-21.21:00:33.000>
    creator = 'ffrederick'
    dependencies = []
    files = ['8001', '27607']
    hgrepos = []
    issue_num = 1723038
    keywords = ['patch']
    message_count = 4.0
    messages = ['52659', '109649', '111158', '173233']
    nosy_count = 6.0
    nosy_names = ['amaury.forgeotdarc', 'ffrederick', 'ysj.ray', 'serhiy.storchaka', 'bentrofatter', 'maarten']
    pr_nums = ['21933']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue1723038'
    versions = ['Python 3.7']

    Activity

    1. ffrederick commented on May 21, 2007

      ffrederickmannequin
      MannequinAuthor

      Here's both menu & items wrappers for ncurses based on curses_panel.
      Feedback appreciated before I try to add support for other functions.

      Regards,
      Fabian

    2. BreamoreBoy commented on Jul 9, 2010

      BreamoreBoymannequin
      Mannequin

      Would someone please comment on the patch, I can't because I don't know anything about the Python C API.

    3. added
      stdlibStandard Library Python modules in the Lib/ directory
      and removed on Jul 9, 2010
    4. added
      type-featureA feature request or enhancement
      and removed
      stdlibStandard Library Python modules in the Lib/ directory
      on Jul 9, 2010
    5. amauryfa commented on Jul 22, 2010

      @amauryfa
      Contributor

      The patch should be amended for python3, then:

      • PyType_Ready() should be used instead of "ob_type = &PyType_Type;"
      • The demo contains "Option choisie :" which should be translated :-)
      • the call::
        PyErr_SetString(PyExc_RuntimeError,
        "remove_lom: can't find Menu Object");
        is wrong: the calling function does not check the error condition, it will be ignored in any case because the only called is the tp_dealloc
      • find_po() is defined but never called
      • the free() method does not do anything, it contains commented out code.

      In short, this patch needs work.

    6. bentrofatter commented on Oct 18, 2012

      bentrofattermannequin
      Mannequin

      I took the curses.panel module as a starting point as well but have made rather a bit more progress with the extension. The attached patch includes a full wrapper around the curses menu extension, tests, documentation, and the necessary additions to setup.py. Feedback would be much appreciated as I'm also most of the way through a wrapper for the curses form extension and would like to get it finished up shortly.

    7. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions