Repository navigation
Update examples to use async and await keywords in asyncio-task.rst #73627
Description
| BPO | 29441 |
|---|---|
| Nosy | @gvanrossum, @berkerpeksag, @1st1, @marco-buttu |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2017-02-07.08:23:53.693>
created_at = <Date 2017-02-04.05:49:52.236>
labels = ['type-feature', '3.7', 'docs', 'expert-asyncio']
title = 'Update examples to use async and await keywords in asyncio-task.rst'
updated_at = <Date 2017-02-07.09:00:28.598>
user = 'https://github.com/berkerpeksag'bugs.python.org fields:
activity = <Date 2017-02-07.09:00:28.598>
actor = 'python-dev'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-07.08:23:53.693>
closer = 'berker.peksag'
components = ['Documentation', 'asyncio']
creation = <Date 2017-02-04.05:49:52.236>
creator = 'berker.peksag'
dependencies = []
files = ['46508']
hgrepos = []
issue_num = 29441
keywords = ['patch']
message_count = 8.0
messages = ['286911', '287038', '287160', '287205', '287206', '287211', '287212', '287213']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'docs@python', 'python-dev', 'berker.peksag', 'yselivanov', 'marco.buttu']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29441'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
Activity
berkerpeksag commentedon Feb 4, 2017
Attached patch converts all examples that use @coroutine decorator in Doc/library/asyncio-task.rst. I also removed the generator example at https://docs.python.org/3/library/asyncio-task.html#example-coroutine-displaying-the-current-date
See bpo-29407 for context.
marco-buttu commentedon Feb 5, 2017
The patch is OK to me. I also executed the examples, and everything works fine :-)
gvanrossum commentedon Feb 6, 2017
LGTM. Thanks!
python-dev commentedon Feb 7, 2017
New changeset 514571268743 by Berker Peksag in branch '3.5':
Issue bpo-29441: Update examples to use async and await keywords in asyncio-task.rst
https://hg.python.org/cpython/rev/514571268743
New changeset 975e03b0aea6 by Berker Peksag in branch '3.6':
Issue bpo-29441: Merge from 3.5
https://hg.python.org/cpython/rev/975e03b0aea6
New changeset ee074604bf0c by Berker Peksag in branch 'default':
Issue bpo-29441: Merge from 3.6
https://hg.python.org/cpython/rev/ee074604bf0c
berkerpeksag commentedon Feb 7, 2017
Thanks for the reviews!
python-dev commentedon Feb 7, 2017
New changeset dbfbdf9dce7889699e1eb7cc4644a911b16665ec by Berker Peksag in branch '3.6':
Issue bpo-29441: Update examples to use async and await keywords in asyncio-task.rst
dbfbdf9
New changeset f76fb14796715fc5abb5a2b68428b29063c3d48e by Berker Peksag in branch '3.6':
Issue bpo-29441: Merge from 3.5
f76fb14
python-dev commentedon Feb 7, 2017
New changeset dbfbdf9dce7889699e1eb7cc4644a911b16665ec by Berker Peksag in branch '3.5':
Issue bpo-29441: Update examples to use async and await keywords in asyncio-task.rst
dbfbdf9
python-dev commentedon Feb 7, 2017
New changeset dbfbdf9dce7889699e1eb7cc4644a911b16665ec by Berker Peksag in branch 'master':
Issue bpo-29441: Update examples to use async and await keywords in asyncio-task.rst
dbfbdf9
New changeset f76fb14796715fc5abb5a2b68428b29063c3d48e by Berker Peksag in branch 'master':
Issue bpo-29441: Merge from 3.5
f76fb14
New changeset 38c1fd9055ad58738643325a2c7682d76496f9ed by Berker Peksag in branch 'master':
Issue bpo-29441: Merge from 3.6
38c1fd9